[PATCH 1/1] scripts: fix cscope breakage

[PATCH 1/1] scripts: fix cscope breakage

[Jiri Slaby]

Commit 66979224c0d2 (scripts: refactor remove structure forward
declarations) introduced a breakage in tags.sh for others than tags.
So make cscope now fails with:
sed: can't read cscope: No such file or directory

Fix it by quoting remove_structs properly.

Guys, for how long has this been in -next? I update -next and run
cscope once a week and this issue is new this week. And the patch is
already in -rc1? WTF?

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Yang Bai <hamo.by@gmail.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michal Marek <mmarek@suse.cz>
---
 scripts/tags.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index 0d6004e..cf7b12f 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -254,6 +254,6 @@ case "$1" in
 esac
 
 # Remove structure forward declarations.
-if [ -n $remove_structs ]; then
+if [ -n "$remove_structs" ]; then
     LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
 fi
-- 
1.7.9.2

Re: [PATCH 1/1] scripts: fix cscope breakage

[Stephen Boyd]

On 04/02/12 04:18, Jiri Slaby wrote:
> Commit 66979224c0d2 (scripts: refactor remove structure forward
> declarations) introduced a breakage in tags.sh for others than tags.
> So make cscope now fails with:
> sed: can't read cscope: No such file or directory
>

Thanks. It was already reported/fixed and a pull request has been sent.

https://lkml.org/lkml/2012/4/1/12

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.