From: Kukjin Kim <kgene.kim@samsung.com>
To: Il Han <corone.il.han@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] mach-exynos: fix ISO C90 warning.
Date: Mon, 02 Apr 2012 11:57:56 -0700 [thread overview]
Message-ID: <4F79F6B4.9080005@samsung.com> (raw)
In-Reply-To: <1333367732-28014-1-git-send-email-corone.il.han@gmail.com>
Il Han wrote:
> ISO C90 forbids mixed declarations and code.
> Fix it.
>
> Signed-off-by: Il Han<corone.il.han@gmail.com>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index e6cc50e..8614aab 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -583,10 +583,11 @@ core_initcall(exynos_core_init);
> #ifdef CONFIG_CACHE_L2X0
> static int __init exynos4_l2x0_cache_init(void)
> {
> + int ret;
> +
> if (soc_is_exynos5250())
> return 0;
>
> - int ret;
> ret = l2x0_of_init(L2_AUX_VAL, L2_AUX_MASK);
> if (!ret) {
> l2x0_regs_phys = virt_to_phys(&l2x0_saved_regs);
Yeah, seems happened wehn merge confilcts resolved.
OK, will apply and if possible, please use following subject form in
next time like others. Every ARM platfomrs use that.
'ARM: EXYNOS: ...'
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-exynos: fix ISO C90 warning.
Date: Mon, 02 Apr 2012 11:57:56 -0700 [thread overview]
Message-ID: <4F79F6B4.9080005@samsung.com> (raw)
In-Reply-To: <1333367732-28014-1-git-send-email-corone.il.han@gmail.com>
Il Han wrote:
> ISO C90 forbids mixed declarations and code.
> Fix it.
>
> Signed-off-by: Il Han<corone.il.han@gmail.com>
> ---
> arch/arm/mach-exynos/common.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index e6cc50e..8614aab 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -583,10 +583,11 @@ core_initcall(exynos_core_init);
> #ifdef CONFIG_CACHE_L2X0
> static int __init exynos4_l2x0_cache_init(void)
> {
> + int ret;
> +
> if (soc_is_exynos5250())
> return 0;
>
> - int ret;
> ret = l2x0_of_init(L2_AUX_VAL, L2_AUX_MASK);
> if (!ret) {
> l2x0_regs_phys = virt_to_phys(&l2x0_saved_regs);
Yeah, seems happened wehn merge confilcts resolved.
OK, will apply and if possible, please use following subject form in
next time like others. Every ARM platfomrs use that.
'ARM: EXYNOS: ...'
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-04-02 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 11:55 [PATCH] mach-exynos: fix ISO C90 warning Il Han
2012-04-02 11:55 ` Il Han
2012-04-02 18:57 ` Kukjin Kim [this message]
2012-04-02 18:57 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79F6B4.9080005@samsung.com \
--to=kgene.kim@samsung.com \
--cc=corone.il.han@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.