From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH 03/11] avr32: fix nop compile fails from system.h split up
Date: Mon, 2 Apr 2012 15:11:25 -0400 [thread overview]
Message-ID: <4F79F9DD.9050203@windriver.com> (raw)
In-Reply-To: <30076.1333345656@redhat.com>
On 12-04-02 01:47 AM, David Howells wrote:
> Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
>> To fix:
>>
>> In file included from kernel/exit.c:61:
>> arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu':
>> arch/avr32/include/asm/mmu_context.h:135: error: implicit
>> declaration of function 'nop'
>
> Better would be to move the definition of nop() into asm/barrier.h to be
> consistent with other arches.
That does seem to make sense. But just to confirm, then I'd end up
deleting the new file, arch/avr32/include/asm/special_insns.h
------------
commit ae473946586680b01c13975a3b674de23ad7c93e
Author: David Howells <dhowells@redhat.com>
Date: Wed Mar 28 18:30:01 2012 +0100
Disintegrate asm/system.h for AVR32
Disintegrate asm/system.h for AVR32. This has not been compiled at all.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
:000000 100644 0000000... f922218... A arch/avr32/include/asm/special_insns.h
------------
...since it only contains the nop definition.
Is that what you had in mind, or is some other content going to
be moved there at a later time?
Thanks,
Paul.
>
> David
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: David Howells <dhowells@redhat.com>
Cc: <torvalds@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>
Subject: Re: [PATCH 03/11] avr32: fix nop compile fails from system.h split up
Date: Mon, 2 Apr 2012 15:11:25 -0400 [thread overview]
Message-ID: <4F79F9DD.9050203@windriver.com> (raw)
In-Reply-To: <30076.1333345656@redhat.com>
On 12-04-02 01:47 AM, David Howells wrote:
> Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
>> To fix:
>>
>> In file included from kernel/exit.c:61:
>> arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu':
>> arch/avr32/include/asm/mmu_context.h:135: error: implicit
>> declaration of function 'nop'
>
> Better would be to move the definition of nop() into asm/barrier.h to be
> consistent with other arches.
That does seem to make sense. But just to confirm, then I'd end up
deleting the new file, arch/avr32/include/asm/special_insns.h
------------
commit ae473946586680b01c13975a3b674de23ad7c93e
Author: David Howells <dhowells@redhat.com>
Date: Wed Mar 28 18:30:01 2012 +0100
Disintegrate asm/system.h for AVR32
Disintegrate asm/system.h for AVR32. This has not been compiled at all.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
:000000 100644 0000000... f922218... A arch/avr32/include/asm/special_insns.h
------------
...since it only contains the nop definition.
Is that what you had in mind, or is some other content going to
be moved there at a later time?
Thanks,
Paul.
>
> David
next prev parent reply other threads:[~2012-04-02 19:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 20:38 [PATCH 00/11] Fix up more asm/system.h fallout Paul Gortmaker
2012-04-01 20:38 ` [PATCH 01/11] irq_work: fix compile failure on MIPS from system.h split Paul Gortmaker
2012-04-02 5:45 ` David Howells
2012-04-01 20:38 ` [PATCH 02/11] ARM: mach-msm: fix compile fail from system.h fallout Paul Gortmaker
2012-04-02 5:44 ` David Howells
2012-04-02 21:16 ` David Brown
2012-04-01 20:38 ` [PATCH 03/11] avr32: fix nop compile fails from system.h split up Paul Gortmaker
2012-04-02 5:47 ` David Howells
2012-04-02 19:11 ` Paul Gortmaker [this message]
2012-04-02 19:11 ` Paul Gortmaker
2012-04-01 20:38 ` [PATCH 04/11] avr32: fix build failures from mis-naming of atmel_nand.h Paul Gortmaker
2012-04-01 20:38 ` [PATCH 05/11] blackfin: fix cmpxchg build fails from system.h fallout Paul Gortmaker
2012-04-02 5:49 ` David Howells
2012-04-01 20:38 ` [PATCH 06/11] parisc: fix missing cmpxchg file error from system.h split Paul Gortmaker
2012-04-02 5:50 ` David Howells
2012-04-01 20:38 ` [PATCH 07/11] sh: fix several build failures from system.h fallout Paul Gortmaker
2012-04-02 1:00 ` Paul Mundt
2012-04-02 18:15 ` Paul Gortmaker
2012-04-02 18:15 ` Paul Gortmaker
2012-04-02 23:57 ` Stephen Rothwell
2012-04-02 23:57 ` Stephen Rothwell
2012-04-05 2:46 ` Paul Gortmaker
2012-04-05 2:49 ` Paul Gortmaker
2012-04-05 15:15 ` Paul Mundt
2012-04-06 6:40 ` linux-next: sh tree (Was:Re: [PATCH 07/11] sh: fix several build failures from system.h fallout) Stephen Rothwell
2012-04-01 20:38 ` [PATCH 08/11] frv: fix warnings in mb93090-mb00/pci-dma.c about implicit EXPORT_SYMBOL Paul Gortmaker
2012-04-02 5:43 ` David Howells
2012-04-01 20:38 ` [PATCH 09/11] firewire: restore the device.h include in linux/firewire.h Paul Gortmaker
2012-04-01 20:38 ` [PATCH 10/11] tile: fix multiple build failures from system.h dismantle Paul Gortmaker
2012-04-02 5:52 ` David Howells
2012-04-02 15:59 ` Chris Metcalf
2012-04-02 15:59 ` Chris Metcalf
2012-04-02 18:05 ` Paul Gortmaker
2012-04-02 18:05 ` Paul Gortmaker
2012-04-01 20:38 ` [PATCH 11/11] asm-generic: add linux/types.h to cmpxchg.h Paul Gortmaker
2012-04-02 5:53 ` David Howells
2012-04-06 6:28 ` Jonas Bonn
2012-04-02 0:03 ` [PATCH 00/11] Fix up more asm/system.h fallout Stephen Rothwell
2012-04-02 5:30 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79F9DD.9050203@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.