All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: kgene.kim@samsung.com, ben-linux@fluff.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/6] ARM: S3C24XX: Add forgotten clock lookup table to S3C2443
Date: Mon, 02 Apr 2012 14:08:10 -0700	[thread overview]
Message-ID: <4F7A153A.5070701@samsung.com> (raw)
In-Reply-To: <201203122000.31216.heiko@sntech.de>

Heiko Stübner wrote:
> When the hsmmc clock lookup was changed to be lookup tables based,
> it seems the S3C2443 was forgotten.
>
> As subsequent patches will want to add more lookups to it, this
> patch adds the base table with the missing hsmmc lookup.
>
> Signed-off-by: Heiko Stuebner<heiko@sntech.de>
> ---
>   arch/arm/mach-s3c24xx/clock-s3c2443.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/clock-s3c2443.c b/arch/arm/mach-s3c24xx/clock-s3c2443.c
> index efb3ac3..bce1cd3 100644
> --- a/arch/arm/mach-s3c24xx/clock-s3c2443.c
> +++ b/arch/arm/mach-s3c24xx/clock-s3c2443.c
> @@ -179,6 +179,10 @@ static struct clk *clks[] __initdata = {
>   	&clk_hsmmc,
>   };
>
> +static struct clk_lookup s3c2443_clk_lookup[] = {
> +	CLKDEV_INIT("s3c-sdhci.1", "mmc_busclk.2",&clk_hsmmc),
> +};
> +
>   void __init s3c2443_init_clocks(int xtal)
>   {
>   	unsigned long epllcon = __raw_readl(S3C2443_EPLLCON);
> @@ -210,6 +214,7 @@ void __init s3c2443_init_clocks(int xtal)
>
>   	s3c_register_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
>   	s3c_disable_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
> +	clkdev_add_table(s3c2443_clk_lookup, ARRAY_SIZE(s3c2443_clk_lookup));
>
>   	s3c_pwmclk_init();
>   }

Uhm..how about mach-s3c24xx/common-s3c2443.c?

I think, we need to sort out some files in mach-s3c24xx/ and some 
remained mach-s3c24.. directories, actually, as you know, we didn't have 
much time to do it last time :)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: S3C24XX: Add forgotten clock lookup table to S3C2443
Date: Mon, 02 Apr 2012 14:08:10 -0700	[thread overview]
Message-ID: <4F7A153A.5070701@samsung.com> (raw)
In-Reply-To: <201203122000.31216.heiko@sntech.de>

Heiko St?bner wrote:
> When the hsmmc clock lookup was changed to be lookup tables based,
> it seems the S3C2443 was forgotten.
>
> As subsequent patches will want to add more lookups to it, this
> patch adds the base table with the missing hsmmc lookup.
>
> Signed-off-by: Heiko Stuebner<heiko@sntech.de>
> ---
>   arch/arm/mach-s3c24xx/clock-s3c2443.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/clock-s3c2443.c b/arch/arm/mach-s3c24xx/clock-s3c2443.c
> index efb3ac3..bce1cd3 100644
> --- a/arch/arm/mach-s3c24xx/clock-s3c2443.c
> +++ b/arch/arm/mach-s3c24xx/clock-s3c2443.c
> @@ -179,6 +179,10 @@ static struct clk *clks[] __initdata = {
>   	&clk_hsmmc,
>   };
>
> +static struct clk_lookup s3c2443_clk_lookup[] = {
> +	CLKDEV_INIT("s3c-sdhci.1", "mmc_busclk.2",&clk_hsmmc),
> +};
> +
>   void __init s3c2443_init_clocks(int xtal)
>   {
>   	unsigned long epllcon = __raw_readl(S3C2443_EPLLCON);
> @@ -210,6 +214,7 @@ void __init s3c2443_init_clocks(int xtal)
>
>   	s3c_register_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
>   	s3c_disable_clocks(init_clocks_off, ARRAY_SIZE(init_clocks_off));
> +	clkdev_add_table(s3c2443_clk_lookup, ARRAY_SIZE(s3c2443_clk_lookup));
>
>   	s3c_pwmclk_init();
>   }

Uhm..how about mach-s3c24xx/common-s3c2443.c?

I think, we need to sort out some files in mach-s3c24xx/ and some 
remained mach-s3c24.. directories, actually, as you know, we didn't have 
much time to do it last time :)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2012-04-02 21:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 18:59 [PATCH 0/6] S3C24XX: Add support for HSSPI on S3C2416/S3C2443 Heiko Stübner
2012-03-12 18:59 ` Heiko Stübner
2012-03-12 19:00 ` [PATCH 1/6] ARM: S3C24XX: Add forgotten clock lookup table to S3C2443 Heiko Stübner
2012-03-12 19:00   ` Heiko Stübner
2012-04-02 21:08   ` Kukjin Kim [this message]
2012-04-02 21:08     ` Kukjin Kim
2012-04-02 22:37     ` Heiko Stübner
2012-04-02 22:37       ` Heiko Stübner
2012-04-25  1:36       ` Kukjin Kim
2012-04-25  1:36         ` Kukjin Kim
2012-03-12 19:01 ` [PATCH 2/6] ARM: S3C24XX: claim spi channels for hsspi in dma-s3c2443 Heiko Stübner
2012-03-12 19:01   ` Heiko Stübner
2012-03-12 19:01 ` [PATCH 3/6] ARM: S3C24XX: Add map entries needed by the s3c64xx-spi devices Heiko Stübner
2012-03-12 19:01   ` Heiko Stübner
2012-03-12 19:02 ` [PATCH 4/6] ARM: S3C24XX: Add clock-lookup entries required by s3c64xx-spi Heiko Stübner
2012-03-12 19:02   ` Heiko Stübner
2012-03-12 19:03 ` [PATCH v2 5/6] ARM: S3C24XX: Add HSSPI setup callback for s3c64xx-spi driver Heiko Stübner
2012-03-12 19:03   ` Heiko Stübner
2012-03-12 19:03 ` [PATCH 6/6] spi/s3c64xx: Allow usage for ARCH_S3C24XX Heiko Stübner
2012-03-12 19:03   ` Heiko Stübner
2012-04-02 19:25 ` [PATCH 0/6] S3C24XX: Add support for HSSPI on S3C2416/S3C2443 Heiko Stübner
2012-04-02 19:25   ` Heiko Stübner
2012-04-02 21:00   ` Kukjin Kim
2012-04-02 21:00     ` Kukjin Kim
2012-04-25  1:37     ` Kukjin Kim
2012-04-25  1:37       ` Kukjin Kim
  -- strict thread matches above, loose matches on Subject: below --
2012-03-04 18:02 Heiko Stübner
2012-03-04 18:03 ` [PATCH 1/6] ARM: S3C24XX: Add forgotten clock lookup table to S3C2443 Heiko Stübner
2012-03-04 18:03   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A153A.5070701@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.