From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] use: fix bit test
Date: Tue, 03 Apr 2012 10:52:37 +0800 [thread overview]
Message-ID: <4F7A65F5.8070807@cn.fujitsu.com> (raw)
In-Reply-To: <4F797660.4070907@suse.de>
On 04/02/2012 05:50 PM, Andreas Färber wrote:
> Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>>
>> use & instead of the wrong &&
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> Patch looks okay but the subject should probably be fixed to say "usb:"
> when applying. :)
>
Thank you!!
Hi, Gerd,
Does this patch have any problem?
could you merge it with "use:"->"usb:" in the title.
(I think it is not good to send another patch for this)
Thanks
Lai
>
>> ---
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 73b0c7f..89c2406 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
>> int level = 0;
>>
>> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
>> - xhci->usbcmd && USBCMD_INTE) {
>> + xhci->usbcmd & USBCMD_INTE) {
>> level = 1;
>> }
>>
>
prev parent reply other threads:[~2012-04-03 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 6:35 [Qemu-devel] [PATCH] use: fix bit test Lai Jiangshan
2012-04-02 9:50 ` Andreas Färber
2012-04-03 2:52 ` Lai Jiangshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7A65F5.8070807@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.