All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] deadlock in ath9k, 3.3.0+ kernel.
Date: Mon, 02 Apr 2012 21:01:16 -0700	[thread overview]
Message-ID: <4F7A760C.90002@candelatech.com> (raw)
In-Reply-To: <20346.29723.444267.19298@gargle.gargle.HOWL>

On 04/02/2012 08:52 PM, Sujith Manoharan wrote:
> Ben Greear wrote:
>> On 04/02/2012 09:34 AM, Manoharan, Sujith wrote:
>>> Patch sent:  http://marc.info/?l=linux-wireless&m=133282325727326&w=2
>>
>> My 3.3.0 ath9k code doesn't look like that patch at all.  Is some
>> extra back-porting needed for 3.3.0???
>>
>>
>> static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta,
>> 			    struct ieee80211_vif *vif)
>> {
>> 	struct ath_node *an;
>> 	an = (struct ath_node *)sta->drv_priv;
>>
>> #ifdef CONFIG_ATH9K_DEBUGFS
>> 	spin_lock(&sc->nodes_lock);
>> 	list_add(&an->list,&sc->nodes);
>> 	spin_unlock(&sc->nodes_lock);
>> #endif
>> 	an->sta = sta;
>> 	an->vif = vif;
>> 	if (sc->sc_flags&  SC_OP_TXAGGR) {
>> 		ath_tx_node_init(sc, an);
>> 		an->maxampdu = 1<<  (IEEE80211_HT_MAX_AMPDU_FACTOR +
>> 				     sta->ht_cap.ampdu_factor);
>> 		an->mpdudensity = parse_mpdudensity(sta->ht_cap.ampdu_density);
>> 	}
>> }
>
> Yeah, this looks like a different issue. What does decodecode (in scripts/ in the kernel
> source tree) show ?

I'm updating to 3.3.1 and will see if I can reproduce the problem.  It could
well be that there was some initial condition that caused this..but nothing
was logged to /var/log/messages, and my serial console buffer didn't show
the start of the problem, so I have no way to tell.

So, I'll let you know if I can hit it again.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>
Subject: Re: deadlock in ath9k, 3.3.0+ kernel.
Date: Mon, 02 Apr 2012 21:01:16 -0700	[thread overview]
Message-ID: <4F7A760C.90002@candelatech.com> (raw)
In-Reply-To: <20346.29723.444267.19298@gargle.gargle.HOWL>

On 04/02/2012 08:52 PM, Sujith Manoharan wrote:
> Ben Greear wrote:
>> On 04/02/2012 09:34 AM, Manoharan, Sujith wrote:
>>> Patch sent:  http://marc.info/?l=linux-wireless&m=133282325727326&w=2
>>
>> My 3.3.0 ath9k code doesn't look like that patch at all.  Is some
>> extra back-porting needed for 3.3.0???
>>
>>
>> static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta,
>> 			    struct ieee80211_vif *vif)
>> {
>> 	struct ath_node *an;
>> 	an = (struct ath_node *)sta->drv_priv;
>>
>> #ifdef CONFIG_ATH9K_DEBUGFS
>> 	spin_lock(&sc->nodes_lock);
>> 	list_add(&an->list,&sc->nodes);
>> 	spin_unlock(&sc->nodes_lock);
>> #endif
>> 	an->sta = sta;
>> 	an->vif = vif;
>> 	if (sc->sc_flags&  SC_OP_TXAGGR) {
>> 		ath_tx_node_init(sc, an);
>> 		an->maxampdu = 1<<  (IEEE80211_HT_MAX_AMPDU_FACTOR +
>> 				     sta->ht_cap.ampdu_factor);
>> 		an->mpdudensity = parse_mpdudensity(sta->ht_cap.ampdu_density);
>> 	}
>> }
>
> Yeah, this looks like a different issue. What does decodecode (in scripts/ in the kernel
> source tree) show ?

I'm updating to 3.3.1 and will see if I can reproduce the problem.  It could
well be that there was some initial condition that caused this..but nothing
was logged to /var/log/messages, and my serial console buffer didn't show
the start of the problem, so I have no way to tell.

So, I'll let you know if I can hit it again.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2012-04-03  4:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 16:16 [ath9k-devel] deadlock in ath9k, 3.3.0+ kernel Ben Greear
2012-04-02 16:16 ` Ben Greear
2012-04-02 16:34 ` [ath9k-devel] " Manoharan, Sujith
2012-04-02 16:34   ` Manoharan, Sujith
2012-04-02 16:58   ` [ath9k-devel] " Ben Greear
2012-04-02 16:58     ` Ben Greear
2012-04-03  3:52     ` [ath9k-devel] " Sujith Manoharan
2012-04-03  3:52       ` Sujith Manoharan
2012-04-03  4:01       ` Ben Greear [this message]
2012-04-03  4:01         ` Ben Greear
2012-04-03  4:06         ` [ath9k-devel] " Sujith Manoharan
2012-04-03  4:06           ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A760C.90002@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.