Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

[Julien Grall <julien.grall@citrix.com>]

On 04/03/2012 08:51 AM, Avi Kivity wrote:
> On 04/02/2012 05:37 PM, Julien Grall wrote:
>    
>>       if (!inited) {
>>           inited = 1;
>> @@ -2814,19 +2830,8 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci,
>>               s->bustype = CIRRUS_BUSTYPE_ISA;
>>       }
>>
>> -    register_ioport_write(0x3c0, 16, 1, cirrus_vga_ioport_write, s);
>> -
>> -    register_ioport_write(0x3b4, 2, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3d4, 2, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3ba, 1, 1, cirrus_vga_ioport_write, s);
>> -    register_ioport_write(0x3da, 1, 1, cirrus_vga_ioport_write, s);
>> -
>> -    register_ioport_read(0x3c0, 16, 1, cirrus_vga_ioport_read, s);
>> -
>> -    register_ioport_read(0x3b4, 2, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3d4, 2, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3ba, 1, 1, cirrus_vga_ioport_read, s);
>> -    register_ioport_read(0x3da, 1, 1, cirrus_vga_ioport_read, s);
>> +    portio_list_init(cirrus_port_list, cirrus_portio_list, s, "cirrus-io");
>> +    portio_list_add(cirrus_port_list, get_system_io(), 0x3b0);
>>
>>      
> Please pass either pci_address_space_io() or isa_io_address_space()
> (you'll have to write the latter) to cirrus_init_common() from its
> callers.  We really want to avoid get_system_io().
>
>    
isa_io_address_space doesn't exist. I will create it, but which
memory region we need to return ? get_system_io () ?