Re: [Qemu-devel] [PATCH] Memory: unify ioport registration

[Julien Grall <julien.grall@citrix.com>]

On 04/03/2012 08:51 AM, Avi Kivity wrote:
> On 04/02/2012 05:37 PM, Julien Grall wrote:
>    
>>       s = g_malloc0(sizeof(SerialState));
>>
>> @@ -820,8 +828,9 @@ SerialState *serial_init(int base, qemu_irq irq, int baudbase,
>>
>>       vmstate_register(NULL, base,&vmstate_serial, s);
>>
>> -    register_ioport_write(base, 8, 1, serial_ioport_write, s);
>> -    register_ioport_read(base, 8, 1, serial_ioport_read, s);
>> +    portio_list_init(serial_port_list, serial_portio_list, s, "serial-io");
>> +    portio_list_add(serial_port_list, get_system_io(), base);
>> +
>>      
> Should we just remove serial_init() and replace it with the serial-isa
> QOM class?
>    
After few researchs, it's seems this function is not used in the
source code. Is that right ?