From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: Device tree support for LPC32xx
Date: Wed, 04 Apr 2012 01:39:37 +0200 [thread overview]
Message-ID: <4F7B8A39.5000701@antcom.de> (raw)
In-Reply-To: <20120403150430.EBA423E0436@localhost>
Hi Grant,
thanks for your notes!
On 03/04/12 17:04, Grant Likely wrote:
>> +postcore_initcall(lpc32xx_gpio_init);
>
> module_platform_driver() please. Also, now that deferred probe is
> merged, there should no longer be any need to mess around with
> initcall levels to get gpio drivers probed early.
With module_platform_driver(), I get a new error reported after this
change, coming much earlier before the GPIO registration (which is
deferred now, of course):
===============================================================
Error requesting gpio 50
...
gpiochip_add: registered GPIOs 0 to 7 on device: gpio_p0
gpiochip_add: registered GPIOs 8 to 31 on device: gpio_p1
gpiochip_add: registered GPIOs 32 to 44 on device: gpio_p2
gpiochip_add: registered GPIOs 45 to 50 on device: gpio_p3
gpiochip_add: registered GPIOs 51 to 78 on device: gpi_p3
gpiochip_add: registered GPIOs 79 to 102 on device: gpo_p3
===============================================================
Seems to be caused by this device tree:
leds {
compatible = "gpio-leds";
led0 {
gpios = <&gpo_p3 1 1>; /* GPO_P3 1, GPIO 80, active low */
linux,default-trigger = "heartbeat";
default-state = "keep";
};
};
Are you sure that module_platform_driver() can already handle
this in v3.4-rc1?
Thanks in advance,
Roland
WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com
Subject: Re: [PATCH] gpio: Device tree support for LPC32xx
Date: Wed, 04 Apr 2012 01:39:37 +0200 [thread overview]
Message-ID: <4F7B8A39.5000701@antcom.de> (raw)
In-Reply-To: <20120403150430.EBA423E0436@localhost>
Hi Grant,
thanks for your notes!
On 03/04/12 17:04, Grant Likely wrote:
>> +postcore_initcall(lpc32xx_gpio_init);
>
> module_platform_driver() please. Also, now that deferred probe is
> merged, there should no longer be any need to mess around with
> initcall levels to get gpio drivers probed early.
With module_platform_driver(), I get a new error reported after this
change, coming much earlier before the GPIO registration (which is
deferred now, of course):
===============================================================
Error requesting gpio 50
...
gpiochip_add: registered GPIOs 0 to 7 on device: gpio_p0
gpiochip_add: registered GPIOs 8 to 31 on device: gpio_p1
gpiochip_add: registered GPIOs 32 to 44 on device: gpio_p2
gpiochip_add: registered GPIOs 45 to 50 on device: gpio_p3
gpiochip_add: registered GPIOs 51 to 78 on device: gpi_p3
gpiochip_add: registered GPIOs 79 to 102 on device: gpo_p3
===============================================================
Seems to be caused by this device tree:
leds {
compatible = "gpio-leds";
led0 {
gpios = <&gpo_p3 1 1>; /* GPO_P3 1, GPIO 80, active low */
linux,default-trigger = "heartbeat";
default-state = "keep";
};
};
Are you sure that module_platform_driver() can already handle
this in v3.4-rc1?
Thanks in advance,
Roland
next prev parent reply other threads:[~2012-04-03 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 22:58 [PATCH] gpio: Device tree support for LPC32xx Roland Stigge
2012-04-02 22:58 ` Roland Stigge
2012-04-03 8:29 ` Arnd Bergmann
2012-04-03 8:29 ` Arnd Bergmann
2012-04-03 9:13 ` Roland Stigge
2012-04-03 9:13 ` Roland Stigge
2012-04-03 15:04 ` Grant Likely
2012-04-03 15:04 ` Grant Likely
2012-04-03 23:39 ` Roland Stigge [this message]
2012-04-03 23:39 ` Roland Stigge
2012-04-03 23:52 ` Roland Stigge
2012-04-03 23:52 ` Roland Stigge
2012-04-04 11:13 ` Mark Brown
2012-04-04 11:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B8A39.5000701@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.