From: Garbat Rafal <rafal.garbat@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
Date: Wed, 4 Apr 2012 13:17:56 +0200 [thread overview]
Message-ID: <4F7C2DE4.3040502@tieto.com> (raw)
In-Reply-To: <20120404111002.GA3463@x220>
On 04/04/2012 01:10 PM, Johan Hedberg wrote:
> On Wed, Apr 04, 2012, Johan Hedberg wrote:
>> Hi Rafal,
>>
>> On Wed, Apr 04, 2012, Garbat Rafal wrote:
>>>> The patch looks ok'ish but it doesn't compile:
>>>>
>>>> audio/avdtp.c: In function ‘avdtp_parse_rej’:
>>>> audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
>>>>
>>>> Secondly, please use a "avdtp:" prefix for the commit message
>>>> ("Bluetooth" is only reserved for kernel patches) and remove the '.'
>>> >from the end of the summary line.
>>>> Johan
>>> Sorry, just a nasty typo. Will fix it and send patch once again.
>> The thing I'm more worried about is that this seems to imply that you've
>> neither run the code nor even tried to compile it. Is that the case?
> I.e. how do you know that the patch is correct if you haven't tested it?
>
> Johan
It was tested (special use case with one of the carkits we had) and I
did this typo when I was porting
this from the other project. Sorry, it was done in a hurry.
prev parent reply other threads:[~2012-04-04 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 17:27 [PATCH] Bluetooth: Finalize discovery after discover message was rejected Rafal Garbat
2012-04-04 10:20 ` Johan Hedberg
2012-04-04 11:05 ` Garbat Rafal
2012-04-04 11:08 ` Johan Hedberg
2012-04-04 11:10 ` Johan Hedberg
2012-04-04 11:17 ` Garbat Rafal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7C2DE4.3040502@tieto.com \
--to=rafal.garbat@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.