* [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
@ 2012-03-09 17:27 Rafal Garbat
2012-04-04 10:20 ` Johan Hedberg
0 siblings, 1 reply; 6+ messages in thread
From: Rafal Garbat @ 2012-03-09 17:27 UTC (permalink / raw)
To: linux-bluetooth; +Cc: rafal.garbat
Finalize discovery and disconnect l2cap after discover
message was rejected.
---
audio/avdtp.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/audio/avdtp.c b/audio/avdtp.c
index cd66fd4..64e5800 100644
--- a/audio/avdtp.c
+++ b/audio/avdtp.c
@@ -3064,6 +3064,12 @@ static gboolean avdtp_parse_rej(struct avdtp *session,
return FALSE;
error("DISCOVER request rejected: %s (%d)",
avdtp_strerror(&err), err.err.error_code);
+ if (session->discov_cb) {
+ session->discov_cb(session, session->seps,
+ &err, session->user_data);
+ session->discov_cb = NULL;
+ session->used_data = NULL;
+ }
return TRUE;
case AVDTP_GET_CAPABILITIES:
case AVDTP_GET_ALL_CAPABILITIES:
--
on behalf of ST-Ericsson
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
2012-03-09 17:27 [PATCH] Bluetooth: Finalize discovery after discover message was rejected Rafal Garbat
@ 2012-04-04 10:20 ` Johan Hedberg
2012-04-04 11:05 ` Garbat Rafal
0 siblings, 1 reply; 6+ messages in thread
From: Johan Hedberg @ 2012-04-04 10:20 UTC (permalink / raw)
To: Rafal Garbat; +Cc: linux-bluetooth
Hi Rafal,
On Fri, Mar 09, 2012, Rafal Garbat wrote:
> Finalize discovery and disconnect l2cap after discover
> message was rejected.
> ---
> audio/avdtp.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/audio/avdtp.c b/audio/avdtp.c
> index cd66fd4..64e5800 100644
> --- a/audio/avdtp.c
> +++ b/audio/avdtp.c
> @@ -3064,6 +3064,12 @@ static gboolean avdtp_parse_rej(struct avdtp *session,
> return FALSE;
> error("DISCOVER request rejected: %s (%d)",
> avdtp_strerror(&err), err.err.error_code);
> + if (session->discov_cb) {
> + session->discov_cb(session, session->seps,
> + &err, session->user_data);
> + session->discov_cb = NULL;
> + session->used_data = NULL;
> + }
> return TRUE;
> case AVDTP_GET_CAPABILITIES:
> case AVDTP_GET_ALL_CAPABILITIES:
The patch looks ok'ish but it doesn't compile:
audio/avdtp.c: In function ‘avdtp_parse_rej’:
audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
Secondly, please use a "avdtp:" prefix for the commit message
("Bluetooth" is only reserved for kernel patches) and remove the '.'
from the end of the summary line.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
2012-04-04 10:20 ` Johan Hedberg
@ 2012-04-04 11:05 ` Garbat Rafal
2012-04-04 11:08 ` Johan Hedberg
0 siblings, 1 reply; 6+ messages in thread
From: Garbat Rafal @ 2012-04-04 11:05 UTC (permalink / raw)
To: Johan Hedberg; +Cc: linux-bluetooth@vger.kernel.org
Hi Johan
On 04/04/2012 12:20 PM, Johan Hedberg wrote:
> Hi Rafal,
>
> On Fri, Mar 09, 2012, Rafal Garbat wrote:
>> Finalize discovery and disconnect l2cap after discover
>> message was rejected.
>> ---
>> audio/avdtp.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/audio/avdtp.c b/audio/avdtp.c
>> index cd66fd4..64e5800 100644
>> --- a/audio/avdtp.c
>> +++ b/audio/avdtp.c
>> @@ -3064,6 +3064,12 @@ static gboolean avdtp_parse_rej(struct avdtp *session,
>> return FALSE;
>> error("DISCOVER request rejected: %s (%d)",
>> avdtp_strerror(&err), err.err.error_code);
>> + if (session->discov_cb) {
>> + session->discov_cb(session, session->seps,
>> + &err, session->user_data);
>> + session->discov_cb = NULL;
>> + session->used_data = NULL;
>> + }
>> return TRUE;
>> case AVDTP_GET_CAPABILITIES:
>> case AVDTP_GET_ALL_CAPABILITIES:
> The patch looks ok'ish but it doesn't compile:
>
> audio/avdtp.c: In function ‘avdtp_parse_rej’:
> audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
>
> Secondly, please use a "avdtp:" prefix for the commit message
> ("Bluetooth" is only reserved for kernel patches) and remove the '.'
> from the end of the summary line.
>
> Johan
Sorry, just a nasty typo. Will fix it and send patch once again.
Rafal
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
2012-04-04 11:05 ` Garbat Rafal
@ 2012-04-04 11:08 ` Johan Hedberg
2012-04-04 11:10 ` Johan Hedberg
0 siblings, 1 reply; 6+ messages in thread
From: Johan Hedberg @ 2012-04-04 11:08 UTC (permalink / raw)
To: Garbat Rafal; +Cc: linux-bluetooth@vger.kernel.org
Hi Rafal,
On Wed, Apr 04, 2012, Garbat Rafal wrote:
> >The patch looks ok'ish but it doesn't compile:
> >
> >audio/avdtp.c: In function ‘avdtp_parse_rej’:
> >audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
> >
> >Secondly, please use a "avdtp:" prefix for the commit message
> >("Bluetooth" is only reserved for kernel patches) and remove the '.'
> >from the end of the summary line.
> >
> >Johan
>
> Sorry, just a nasty typo. Will fix it and send patch once again.
The thing I'm more worried about is that this seems to imply that you've
neither run the code nor even tried to compile it. Is that the case?
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
2012-04-04 11:08 ` Johan Hedberg
@ 2012-04-04 11:10 ` Johan Hedberg
2012-04-04 11:17 ` Garbat Rafal
0 siblings, 1 reply; 6+ messages in thread
From: Johan Hedberg @ 2012-04-04 11:10 UTC (permalink / raw)
To: Garbat Rafal, linux-bluetooth@vger.kernel.org
On Wed, Apr 04, 2012, Johan Hedberg wrote:
> Hi Rafal,
>
> On Wed, Apr 04, 2012, Garbat Rafal wrote:
> > >The patch looks ok'ish but it doesn't compile:
> > >
> > >audio/avdtp.c: In function ‘avdtp_parse_rej’:
> > >audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
> > >
> > >Secondly, please use a "avdtp:" prefix for the commit message
> > >("Bluetooth" is only reserved for kernel patches) and remove the '.'
> > >from the end of the summary line.
> > >
> > >Johan
> >
> > Sorry, just a nasty typo. Will fix it and send patch once again.
>
> The thing I'm more worried about is that this seems to imply that you've
> neither run the code nor even tried to compile it. Is that the case?
I.e. how do you know that the patch is correct if you haven't tested it?
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: Finalize discovery after discover message was rejected.
2012-04-04 11:10 ` Johan Hedberg
@ 2012-04-04 11:17 ` Garbat Rafal
0 siblings, 0 replies; 6+ messages in thread
From: Garbat Rafal @ 2012-04-04 11:17 UTC (permalink / raw)
To: Johan Hedberg; +Cc: linux-bluetooth@vger.kernel.org
On 04/04/2012 01:10 PM, Johan Hedberg wrote:
> On Wed, Apr 04, 2012, Johan Hedberg wrote:
>> Hi Rafal,
>>
>> On Wed, Apr 04, 2012, Garbat Rafal wrote:
>>>> The patch looks ok'ish but it doesn't compile:
>>>>
>>>> audio/avdtp.c: In function ‘avdtp_parse_rej’:
>>>> audio/avdtp.c:3071:11: error: ‘struct avdtp’ has no member named ‘used_data’
>>>>
>>>> Secondly, please use a "avdtp:" prefix for the commit message
>>>> ("Bluetooth" is only reserved for kernel patches) and remove the '.'
>>> >from the end of the summary line.
>>>> Johan
>>> Sorry, just a nasty typo. Will fix it and send patch once again.
>> The thing I'm more worried about is that this seems to imply that you've
>> neither run the code nor even tried to compile it. Is that the case?
> I.e. how do you know that the patch is correct if you haven't tested it?
>
> Johan
It was tested (special use case with one of the carkits we had) and I
did this typo when I was porting
this from the other project. Sorry, it was done in a hurry.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-04 11:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-09 17:27 [PATCH] Bluetooth: Finalize discovery after discover message was rejected Rafal Garbat
2012-04-04 10:20 ` Johan Hedberg
2012-04-04 11:05 ` Garbat Rafal
2012-04-04 11:08 ` Johan Hedberg
2012-04-04 11:10 ` Johan Hedberg
2012-04-04 11:17 ` Garbat Rafal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.