Re: [PATCH] af9035: add several new USB IDs

[Antti Palosaari <crope@iki.fi>]

On 04.04.2012 14:47, Gianluca Gennari wrote:
> Add several new USB IDs extracted from the Windows and Linux drivers published
> by the manufacturers (Terratec and AVerMedia).
> +	[AF9035_07CA_0867] = {
> +		USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
>   	[AF9035_07CA_1867] = {
>   		USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
> +	[AF9035_07CA_3867] = {
> +		USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
>   	[AF9035_07CA_A867] = {
>   		USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
> +	[AF9035_07CA_B867] = {
> +		USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},

It have been common practise to use product names for USB PID 
definitions instead of USB ID numbers. I vote to continue that practise.

Also, I am not very sure if it is wise to add new IDs without any 
testing. Likely those are just reference design and will work, but 
sometimes there is also some changes done for schematic wiring. 
Especially for Avermedia, see hacks needed some AF9015 Avermedia 
devices. They have put invalid data to eeprom and thus hacks are needed 
for overriding tuner IDs etc.
Not to mention, driver supports also dynamic IDs and even device ID is 
missing user can load driver using dynamic ID and report it working or 
non-working.

Anyone else any thoughts about adding IDs without testing ?

regards
Antti
-- 
http://palosaari.fi/