All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: OMAP4: hwmod_data: Name the common irq for McBSP ports
Date: Wed, 4 Apr 2012 21:06:22 +0200	[thread overview]
Message-ID: <4F7C9BAE.1030601@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204040946230.8000@utopia.booyaka.com>

Hi Paul,

On 4/4/2012 5:46 PM, Paul Walmsley wrote:
> + Benoît
>
> Hi Benoît
>
> On Mon, 19 Mar 2012, Peter Ujfalusi wrote:
>
>> Use 'common' as name for the common irq number in hwmod data for the McBSP
>> ports. The same name already in use for OMAP2430, and OMAP3.
>>
>> Signed-off-by: Peter Ujfalusi<peter.ujfalusi@ti.com>
>
> care to Ack this one for 3.5?

That looks good to me.

Acked-by: Benoit Cousson <b-cousson@ti.com>

Regards,
Benoit


>
>
> - Paul
>
>
>> ---
>>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    8 ++++----
>>   1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index ef0524c..f8058b7 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -2942,7 +2942,7 @@ static struct omap_hwmod_class omap44xx_mcbsp_hwmod_class = {
>>   /* mcbsp1 */
>>   static struct omap_hwmod omap44xx_mcbsp1_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp1_irqs[] = {
>> -	{ .irq = 17 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 17 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3017,7 +3017,7 @@ static struct omap_hwmod omap44xx_mcbsp1_hwmod = {
>>   /* mcbsp2 */
>>   static struct omap_hwmod omap44xx_mcbsp2_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp2_irqs[] = {
>> -	{ .irq = 22 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 22 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3092,7 +3092,7 @@ static struct omap_hwmod omap44xx_mcbsp2_hwmod = {
>>   /* mcbsp3 */
>>   static struct omap_hwmod omap44xx_mcbsp3_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp3_irqs[] = {
>> -	{ .irq = 23 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 23 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3167,7 +3167,7 @@ static struct omap_hwmod omap44xx_mcbsp3_hwmod = {
>>   /* mcbsp4 */
>>   static struct omap_hwmod omap44xx_mcbsp4_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp4_irqs[] = {
>> -	{ .irq = 16 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 16 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> --
>> 1.7.8.5
>>
>
>
> - Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP4: hwmod_data: Name the common irq for McBSP ports
Date: Wed, 4 Apr 2012 21:06:22 +0200	[thread overview]
Message-ID: <4F7C9BAE.1030601@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204040946230.8000@utopia.booyaka.com>

Hi Paul,

On 4/4/2012 5:46 PM, Paul Walmsley wrote:
> + Beno?t
>
> Hi Beno?t
>
> On Mon, 19 Mar 2012, Peter Ujfalusi wrote:
>
>> Use 'common' as name for the common irq number in hwmod data for the McBSP
>> ports. The same name already in use for OMAP2430, and OMAP3.
>>
>> Signed-off-by: Peter Ujfalusi<peter.ujfalusi@ti.com>
>
> care to Ack this one for 3.5?

That looks good to me.

Acked-by: Benoit Cousson <b-cousson@ti.com>

Regards,
Benoit


>
>
> - Paul
>
>
>> ---
>>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    8 ++++----
>>   1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index ef0524c..f8058b7 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -2942,7 +2942,7 @@ static struct omap_hwmod_class omap44xx_mcbsp_hwmod_class = {
>>   /* mcbsp1 */
>>   static struct omap_hwmod omap44xx_mcbsp1_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp1_irqs[] = {
>> -	{ .irq = 17 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 17 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3017,7 +3017,7 @@ static struct omap_hwmod omap44xx_mcbsp1_hwmod = {
>>   /* mcbsp2 */
>>   static struct omap_hwmod omap44xx_mcbsp2_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp2_irqs[] = {
>> -	{ .irq = 22 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 22 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3092,7 +3092,7 @@ static struct omap_hwmod omap44xx_mcbsp2_hwmod = {
>>   /* mcbsp3 */
>>   static struct omap_hwmod omap44xx_mcbsp3_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp3_irqs[] = {
>> -	{ .irq = 23 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 23 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> @@ -3167,7 +3167,7 @@ static struct omap_hwmod omap44xx_mcbsp3_hwmod = {
>>   /* mcbsp4 */
>>   static struct omap_hwmod omap44xx_mcbsp4_hwmod;
>>   static struct omap_hwmod_irq_info omap44xx_mcbsp4_irqs[] = {
>> -	{ .irq = 16 + OMAP44XX_IRQ_GIC_START },
>> +	{ .name = "common", .irq = 16 + OMAP44XX_IRQ_GIC_START },
>>   	{ .irq = -1 }
>>   };
>>
>> --
>> 1.7.8.5
>>
>
>
> - Paul

  reply	other threads:[~2012-04-04 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:12 [PATCH 1/2] ARM: OMAP3: hwmod_data: Rename the common irq for McBSP ports Peter Ujfalusi
2012-03-19 15:12 ` Peter Ujfalusi
2012-03-19 15:12 ` [PATCH 2/2] ARM: OMAP4: hwmod_data: Name " Peter Ujfalusi
2012-03-19 15:12   ` Peter Ujfalusi
2012-04-04 15:46   ` Paul Walmsley
2012-04-04 15:46     ` Paul Walmsley
2012-04-04 19:06     ` Cousson, Benoit [this message]
2012-04-04 19:06       ` Cousson, Benoit
2012-04-04 15:46 ` [PATCH 1/2] ARM: OMAP3: hwmod_data: Rename " Paul Walmsley
2012-04-04 15:46   ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C9BAE.1030601@ti.com \
    --to=b-cousson@ti.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.