All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: Shubhrajyoti D <shubhrajyoti@ti.com>,
	linux-omap@vger.kernel.org, tony@atomide.com,
	Tasslehoff Kjappfot <tasskjapp@gmail.com>,
	w.sang@pengutronix.de, linux-i2c@vger.kernel.org,
	ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153
Date: Wed, 4 Apr 2012 14:22:07 -0500	[thread overview]
Message-ID: <4F7C9F5F.8010206@ti.com> (raw)
In-Reply-To: <CAM=Q2cu8k8n2w8_=8VCFcFTTgywqc_Vk_eM_DDTap3YeYyAH2g@mail.gmail.com>

Hi Shubhro,

On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote:
> Hi Jon,
>
>
>>> +       if (dev->flags&    OMAP_I2C_FLAG_APPLY_ERRATA_I207)
>>>
>>> +               dev->errata |= I2C_OMAP_ERRATA_I207;
>>> +
>>>         if (dev->rev<= OMAP_I2C_REV_ON_3430_3530)
>>>                 dev->errata |= I2C_OMAP3_1P153;
>>
>>
>> The errata ID is not correct. I believe that 1P153 is referring to the
>> section number in the errata doc and not the errata ID. The errata ID should
>> be i451 in the latest OMAP34xx and OMAP36xx docs.
>>
>> Please can you update this? The section number changed in the latest errata
>> docs and it took me a minute to find this.
>
> Do you mind if that is a separate patch?

Not at all and in fact it probably should be.

Thanks
Jon

WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153
Date: Wed, 4 Apr 2012 14:22:07 -0500	[thread overview]
Message-ID: <4F7C9F5F.8010206@ti.com> (raw)
In-Reply-To: <CAM=Q2cu8k8n2w8_=8VCFcFTTgywqc_Vk_eM_DDTap3YeYyAH2g@mail.gmail.com>

Hi Shubhro,

On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote:
> Hi Jon,
>
>
>>> +       if (dev->flags&    OMAP_I2C_FLAG_APPLY_ERRATA_I207)
>>>
>>> +               dev->errata |= I2C_OMAP_ERRATA_I207;
>>> +
>>>         if (dev->rev<= OMAP_I2C_REV_ON_3430_3530)
>>>                 dev->errata |= I2C_OMAP3_1P153;
>>
>>
>> The errata ID is not correct. I believe that 1P153 is referring to the
>> section number in the errata doc and not the errata ID. The errata ID should
>> be i451 in the latest OMAP34xx and OMAP36xx docs.
>>
>> Please can you update this? The section number changed in the latest errata
>> docs and it took me a minute to find this.
>
> Do you mind if that is a separate patch?

Not at all and in fact it probably should be.

Thanks
Jon

  reply	other threads:[~2012-04-04 19:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03 16:02 [PATCHv5 00/18] I2C updates Shubhrajyoti D
2012-04-03 16:02 ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 02/18] I2C: OMAP: Remove reset at init Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 03/18] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 06/18] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 08/18] I2C: OMAP: Fix the error handling Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 12/18] I2C: OMAP: Fix the crash in i2c remove Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
2012-04-03 16:02 ` [PATCHv5 14/18] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
     [not found] ` <1333468957-5999-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-04-03 16:02   ` [PATCHv5 01/18] I2C: OMAP: make omap_i2c_unidle/idle functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 04/18] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 05/18] I2C: OMAP: Fix the interrupt clearing in OMAP4 Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 07/18] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 09/18] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 10/18] I2C: OMAP: Don't check if wait_for_completion_timeout() returns less than zero Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 11/18] I2C: OMAP: use devm_* functions Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 13/18] I2C: OMAP: Handle error check for pm runtime Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 15/18] I2C: OMAP: make the read ready processing a separate function Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
2012-04-03 16:02   ` [PATCHv5 17/18] I2C: OMAP: Do not set the XUDF if the underflow is not reached Shubhrajyoti D
2012-04-03 16:02     ` Shubhrajyoti D
     [not found]     ` <CAEgRx2ye7VLfTDmpLdsJE=6qKzDngd=zpGK3Xn8UR3moioXYQw@mail.gmail.com>
2012-04-03 16:32       ` Shubhrajyoti
2012-04-03 16:32         ` Shubhrajyoti
2012-04-03 16:02 ` [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153 Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D
     [not found]   ` <1333468957-5999-17-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-04-04 16:32     ` Jon Hunter
2012-04-04 16:32       ` Jon Hunter
2012-04-04 17:45       ` Shubhrajyoti Datta
2012-04-04 17:45         ` Shubhrajyoti Datta
2012-04-04 19:22         ` Jon Hunter [this message]
2012-04-04 19:22           ` Jon Hunter
2012-04-05 16:21           ` Jon Hunter
2012-04-05 16:21             ` Jon Hunter
2012-04-03 16:02 ` [PATCHv5 18/18] ARM: OMAP4: hwmod data: I2C: add flag for context restore Shubhrajyoti D
2012-04-03 16:02   ` Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C9F5F.8010206@ti.com \
    --to=jon-hunter@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=omaplinuxkernel@gmail.com \
    --cc=shubhrajyoti@ti.com \
    --cc=tasskjapp@gmail.com \
    --cc=tony@atomide.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.