All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: at91: Export at91_ramc_base
@ 2012-03-30 21:03 manabian at gmail.com
  2012-03-31 21:23 ` Sergei Shtylyov
  2012-04-06 12:56 ` Nicolas Ferre
  0 siblings, 2 replies; 3+ messages in thread
From: manabian at gmail.com @ 2012-03-30 21:03 UTC (permalink / raw)
  To: linux-arm-kernel

From: Joachim Eastwood <joachim.eastwood@jotron.com>

After commit f363c407b42c4 building at91_cf as a module fails with:
  ERROR: "at91_ramc_base" [drivers/pcmcia/at91_cf.ko] undefined!
  make[1]: *** [__modpost] Error 1
  make: *** [modules] Error 2

Export at91_ramc_base symbol to allow drivers using at91_ramc_*
functions to be built as modules again.

Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com>
---

This makes at91_cf compile again but it still doesn't work. Still
trying to figure out why.

 arch/arm/mach-at91/setup.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
index 1083739..aa010a9 100644
--- a/arch/arm/mach-at91/setup.c
+++ b/arch/arm/mach-at91/setup.c
@@ -53,6 +53,7 @@ void __init at91_init_interrupts(unsigned int *priority)
 }
 
 void __iomem *at91_ramc_base[2];
+EXPORT_SYMBOL(at91_ramc_base);
 
 void __init at91_ioremap_ramc(int id, u32 addr, u32 size)
 {
-- 
1.7.9.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: at91: Export at91_ramc_base
  2012-03-30 21:03 [PATCH] ARM: at91: Export at91_ramc_base manabian at gmail.com
@ 2012-03-31 21:23 ` Sergei Shtylyov
  2012-04-06 12:56 ` Nicolas Ferre
  1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2012-03-31 21:23 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 31-03-2012 1:03, manabian at gmail.com wrote:

> From: Joachim Eastwood<joachim.eastwood@jotron.com>

> After commit f363c407b42c4 building at91_cf as a module fails with:

    Please also specify that commit's summary in parens.

>    ERROR: "at91_ramc_base" [drivers/pcmcia/at91_cf.ko] undefined!
>    make[1]: *** [__modpost] Error 1
>    make: *** [modules] Error 2

> Export at91_ramc_base symbol to allow drivers using at91_ramc_*
> functions to be built as modules again.

> Signed-off-by: Joachim Eastwood<joachim.eastwood@jotron.com>

WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: at91: Export at91_ramc_base
  2012-03-30 21:03 [PATCH] ARM: at91: Export at91_ramc_base manabian at gmail.com
  2012-03-31 21:23 ` Sergei Shtylyov
@ 2012-04-06 12:56 ` Nicolas Ferre
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2012-04-06 12:56 UTC (permalink / raw)
  To: linux-arm-kernel

On 03/30/2012 11:03 PM, manabian at gmail.com :
> From: Joachim Eastwood <joachim.eastwood@jotron.com>
> 
> After commit f363c407b42c4 building at91_cf as a module fails with:
>   ERROR: "at91_ramc_base" [drivers/pcmcia/at91_cf.ko] undefined!
>   make[1]: *** [__modpost] Error 1
>   make: *** [modules] Error 2
> 
> Export at91_ramc_base symbol to allow drivers using at91_ramc_*
> functions to be built as modules again.
> 
> Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com>

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

and queued in at91-fixes for 3.4

(I modified commit message in relation with Sergei's comment).

Thanks, best regards,


> ---
> 
> This makes at91_cf compile again but it still doesn't work. Still
> trying to figure out why.
> 
>  arch/arm/mach-at91/setup.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
> index 1083739..aa010a9 100644
> --- a/arch/arm/mach-at91/setup.c
> +++ b/arch/arm/mach-at91/setup.c
> @@ -53,6 +53,7 @@ void __init at91_init_interrupts(unsigned int *priority)
>  }
>  
>  void __iomem *at91_ramc_base[2];
> +EXPORT_SYMBOL(at91_ramc_base);
>  
>  void __init at91_ioremap_ramc(int id, u32 addr, u32 size)
>  {


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-06 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-30 21:03 [PATCH] ARM: at91: Export at91_ramc_base manabian at gmail.com
2012-03-31 21:23 ` Sergei Shtylyov
2012-04-06 12:56 ` Nicolas Ferre

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.