All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: RFC: deprecating/removing the legacy mode of devpts
Date: Sun, 08 Apr 2012 22:15:32 +0400	[thread overview]
Message-ID: <4F81D5C4.9000503@openvz.org> (raw)
In-Reply-To: <4F80892A.7050104@zytor.com>

H. Peter Anvin wrote:
> Currently, devpts supports a legacy mode where only one instance exists.
>   For backwards compatibility, this is also the default mode, but the
> right thing should be to migrate everyone over to the "newinstance" scheme.
>
> However, it is increasingly clear that that is not happening; neither
> the distros nor udev support this by default at this point.
>
> I think it might be time we set a sunset date for the legacy mode,
> probably around kernel 3.9 at this point.
>
> The big change is that /dev/ptmx instead of being a device node should
> be a symlink to /dev/pts/ptmx, which is then either chmodded to the
> proper permissions, or given proper permissions via the ptmxmode mount
> options to devpts.  The latter is probably preferable from a technical
> point of view since it doesn't create a "gap".
>
> As such, I would like to suggest the following:
>
> 1. For 3.5, add this to feature-removal.txt.
> 2. For 3.6, remove CONFIG_DEVPTS_MULTIPLE_INSTANCES as a configuration
>     option, and printk a warning if devpts is mounted without the
>     "newinstance" option.
> 3. For 3.9 remove the legacy support including support for a ptmx node
>     outside the devpts filesystem.
>
> 	-hpa
>

I think we should give the way to test compatibility as early as possible, so:
2'. For 3.6 add CONFIG_DEVPTS_LEGACY_INSTANCE =y by default, if it =n:
     always create new instance (ignore "newinstance") and remove "ptmx" from sysfs.

  parent reply	other threads:[~2012-04-08 18:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07 18:36 RFC: deprecating/removing the legacy mode of devpts H. Peter Anvin
2012-04-07 19:20 ` Alan Cox
2012-04-07 20:02   ` H. Peter Anvin
2012-04-07 21:27     ` Ted Ts'o
2012-04-07 22:03       ` H. Peter Anvin
2012-04-08  7:30         ` Kay Sievers
2012-04-08 18:00           ` H. Peter Anvin
2012-04-08 19:16             ` Kay Sievers
2012-04-11 23:53               ` Greg Kroah-Hartman
2012-04-11 23:55                 ` H. Peter Anvin
2012-04-12  0:30                   ` Greg Kroah-Hartman
2012-04-12  0:38                     ` Kay Sievers
2012-04-12  1:14                       ` Greg Kroah-Hartman
2012-04-12  1:08               ` Al Viro
2012-04-12  1:56                 ` H. Peter Anvin
2012-04-12  2:26                   ` Al Viro
2012-04-12  2:48                     ` H. Peter Anvin
2012-04-12  3:04                       ` Al Viro
2012-04-12  3:07                         ` H. Peter Anvin
2012-04-12  2:27                 ` Kay Sievers
2012-04-12  2:45                   ` Al Viro
2012-04-12  2:48                     ` Kay Sievers
2012-04-12  2:53                   ` H. Peter Anvin
2012-04-12  3:02                     ` Kay Sievers
2012-04-08 17:20         ` Alan Cox
2012-04-07 20:04   ` H. Peter Anvin
2012-04-08 18:15 ` Konstantin Khlebnikov [this message]
2012-04-08 22:18   ` Alan Cox
2012-04-08 22:26     ` H. Peter Anvin
2012-04-08 22:46       ` Alan Cox
2012-04-08 22:45         ` H. Peter Anvin
2012-04-09  3:15           ` Theodore Tso
2012-04-09 12:43             ` Kay Sievers
2012-04-09 13:37               ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F81D5C4.9000503@openvz.org \
    --to=khlebnikov@openvz.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.