Re: [PATCH] staging: zsmalloc: fix memory leak

[Seth Jennings <sjenning@linux.vnet.ibm.com>]

Hey Greg,

Haven't heard back from you on this patch and it needs to
get into the 3.4 -rc releases ASAP.  It fixes a substantial
memory leak when frontswap/zcache are enabled.

Let me know if you need me to repost.

The patch was sent on 4/2.

Thanks,
Seth

On 04/04/2012 11:26 AM, Seth Jennings wrote:
> On 04/04/2012 11:03 AM, Dan Magenheimer wrote:
>>> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
>>> Sent: Monday, April 02, 2012 8:14 AM
>>> To: Greg Kroah-Hartman
>>> Cc: Nitin Gupta; Dan Magenheimer; Konrad Rzeszutek Wilk; Robert Jennings; Seth Jennings;
>>> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; linux-mm@kvack.org
>>> Subject: [PATCH] staging: zsmalloc: fix memory leak
>>>
>>> From: Nitin Gupta <ngupta@vflare.org>
>>>
>>> This patch fixes a memory leak in zsmalloc where the first
>>> subpage of each zspage is leaked when the zspage is freed.
>>>
>>> Based on 3.4-rc1.
>>>
>>> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
>>> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>>
>> This is a rather severe memory leak and will affect most
>> benchmarking anyone does to evaluate zcache in 3.4 (e.g. as
>> to whether zcache is suitable for promotion), so t'would be nice
>> to get this patch in for -rc2.  (Note it fixes a "regression"
>> since it affects zcache only in 3.4+ because the fix is to
>> the new zsmalloc allocator... so no change to stable trees.)
>>
>> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
> 
> Thanks Dan for this clarification and the Ack.
> 
> I should have tagged this as urgent for the 3.4 release
> and no impact on stable trees, since 3.4 is the first release
> with this code.
> 
> --
> Seth

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>