From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: implement pinctrl deferred probing
Date: Tue, 10 Apr 2012 09:36:26 -0600 [thread overview]
Message-ID: <4F84537A.2020300@wwwdotorg.org> (raw)
In-Reply-To: <1334045048-15566-1-git-send-email-linus.walleij@stericsson.com>
On 04/10/2012 02:04 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> If drivers try to obtain pinctrl handles for a pin controller that
> has not yet registered to the subsystem, we need to be able to
> back out and retry with deferred probing. So let's return
> -EPROBE_DEFER whenever this location fails.
>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This looks fine, except:
> @@ -521,8 +521,11 @@ static int add_setting(struct pinctrl *p, struct pinctrl_map const *map)
> dev_err(p->dev, "unknown pinctrl device %s in map entry",
> map->ctrl_dev_name);
Perhaps this dev_err (and the one in the other hunk) should be
downgraded to warn/info/debug?
> + /*
> + * OK let us guess that the driver is not there yet, and
> + * let's defer obtaining this pinctrl handle to later...
> + */
> + return -EPROBE_DEFER;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Dong Aisheng <dong.aisheng@linaro.org>,
Rajendra Nayak <rajendra.nayak@linaro.org>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] pinctrl: implement pinctrl deferred probing
Date: Tue, 10 Apr 2012 09:36:26 -0600 [thread overview]
Message-ID: <4F84537A.2020300@wwwdotorg.org> (raw)
In-Reply-To: <1334045048-15566-1-git-send-email-linus.walleij@stericsson.com>
On 04/10/2012 02:04 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> If drivers try to obtain pinctrl handles for a pin controller that
> has not yet registered to the subsystem, we need to be able to
> back out and retry with deferred probing. So let's return
> -EPROBE_DEFER whenever this location fails.
>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This looks fine, except:
> @@ -521,8 +521,11 @@ static int add_setting(struct pinctrl *p, struct pinctrl_map const *map)
> dev_err(p->dev, "unknown pinctrl device %s in map entry",
> map->ctrl_dev_name);
Perhaps this dev_err (and the one in the other hunk) should be
downgraded to warn/info/debug?
> + /*
> + * OK let us guess that the driver is not there yet, and
> + * let's defer obtaining this pinctrl handle to later...
> + */
> + return -EPROBE_DEFER;
> }
next prev parent reply other threads:[~2012-04-10 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:04 [PATCH] pinctrl: implement pinctrl deferred probing Linus Walleij
2012-04-10 8:04 ` Linus Walleij
2012-04-10 15:36 ` Stephen Warren [this message]
2012-04-10 15:36 ` Stephen Warren
2012-04-11 8:35 ` Linus Walleij
2012-04-11 8:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F84537A.2020300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.