From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes
Date: Tue, 10 Apr 2012 23:28:19 -0600 [thread overview]
Message-ID: <4F851673.6030000@wwwdotorg.org> (raw)
In-Reply-To: <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 04/10/2012 10:27 PM, Olof Johansson wrote:
...
> On Tue, Apr 10, 2012 at 4:19 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> Add nodes for the Tegra30 AHUB and I2S controllers.
...
>> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
...
>> + ahub@70080000 {
>
> No need for unit address here since there's only one node with this
> name -- "ahub {" is sufficient.
Is there actually a benefit from leaving it out though?
>> + compatible = "nvidia,tegra30-ahub";
>> + reg = <0x70080000 0x200 0x70080200 0x100>;
>
> Why not just use 0x70080000 0x300?
The register space is logically divided into two chunks; the first for
the DMA FIFOs and the second for the AHUB routing registers. Future
chips may change the relative positions and sizes of these two chunks,
hence I figured it was best to model them independently even though
they're contiguous in Tegra30.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes
Date: Tue, 10 Apr 2012 23:28:19 -0600 [thread overview]
Message-ID: <4F851673.6030000@wwwdotorg.org> (raw)
In-Reply-To: <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA@mail.gmail.com>
On 04/10/2012 10:27 PM, Olof Johansson wrote:
...
> On Tue, Apr 10, 2012 at 4:19 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Add nodes for the Tegra30 AHUB and I2S controllers.
...
>> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
...
>> + ahub at 70080000 {
>
> No need for unit address here since there's only one node with this
> name -- "ahub {" is sufficient.
Is there actually a benefit from leaving it out though?
>> + compatible = "nvidia,tegra30-ahub";
>> + reg = <0x70080000 0x200 0x70080200 0x100>;
>
> Why not just use 0x70080000 0x300?
The register space is logically divided into two chunks; the first for
the DMA FIFOs and the second for the AHUB routing registers. Future
chips may change the relative positions and sizes of these two chunks,
hence I figured it was best to model them independently even though
they're contiguous in Tegra30.
next prev parent reply other threads:[~2012-04-11 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 23:19 [PATCH V2 1/5] ARM: tegra: provide clock aliases for AHUB configlink Stephen Warren
2012-04-10 23:19 ` Stephen Warren
[not found] ` <1334099980-19527-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-10 23:19 ` [PATCH V2 2/5] ARM: tegra: set up audio clocks for tegra30 dt Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-10 23:19 ` [PATCH V2 3/5] ARM: tegra: add AUXDATA required for audio Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-10 23:19 ` [PATCH V2 4/5] ARM: dt: tegra30.dtsi: Add audio-related nodes Stephen Warren
2012-04-10 23:19 ` Stephen Warren
2012-04-11 4:27 ` Olof Johansson
2012-04-11 4:27 ` Olof Johansson
[not found] ` <CAOesGMhDDenRK_GeR=jWJbcoacRMUPnjFu5w4DCyUWC=CadnbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-11 5:28 ` Stephen Warren [this message]
2012-04-11 5:28 ` Stephen Warren
2012-04-13 20:59 ` Olof Johansson
2012-04-13 20:59 ` Olof Johansson
2012-04-10 23:19 ` [PATCH V2 5/5] ARM: dt: tegra cardhu: basic audio support Stephen Warren
2012-04-10 23:19 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F851673.6030000@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.