All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [PATCH v4 04/12] ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus
Date: Wed, 11 Apr 2012 09:49:28 +0200	[thread overview]
Message-ID: <4F853788.2030007@antcom.de> (raw)
In-Reply-To: <20120411003528.27059.8836.stgit@dusk>

On 04/11/2012 02:35 AM, Paul Walmsley wrote:
> Also interesting is that drivers/usb/host/ohci-nxp.c contains a stub
> for ocpi_enable() - perhaps the NXP chips use a similar OCPI IP block?

I'd rather suspect a copy-paste error here since ocpi_enable() is unused
in ohci-nxp.c and the extern declaration looks like an incomplete but
intended removal.

Will probably just remove this reference in my DT patchset.

Roland

WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 04/12] ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus
Date: Wed, 11 Apr 2012 09:49:28 +0200	[thread overview]
Message-ID: <4F853788.2030007@antcom.de> (raw)
In-Reply-To: <20120411003528.27059.8836.stgit@dusk>

On 04/11/2012 02:35 AM, Paul Walmsley wrote:
> Also interesting is that drivers/usb/host/ohci-nxp.c contains a stub
> for ocpi_enable() - perhaps the NXP chips use a similar OCPI IP block?

I'd rather suspect a copy-paste error here since ocpi_enable() is unused
in ohci-nxp.c and the extern declaration looks like an incomplete but
intended removal.

Will probably just remove this reference in my DT patchset.

Roland

  reply	other threads:[~2012-04-11  7:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  0:35 [PATCH v4 00/12] ARM: OMAP: resolve some warnings Paul Walmsley
2012-04-11  0:35 ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 01/12] ARM: OMAP2+: declare file-local functions as static Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  8:43   ` Arnd Bergmann
2012-04-11  8:43     ` Arnd Bergmann
2012-04-11 18:16     ` Paul Walmsley
2012-04-11 18:16       ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 02/12] ARM: OMAP: add includes for missing prototypes Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 03/12] ARM: OMAP1: OCPI: move to mach-omap1/ Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 04/12] ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  7:49   ` Roland Stigge [this message]
2012-04-11  7:49     ` Roland Stigge
2012-04-11 18:19     ` Paul Walmsley
2012-04-11 18:19       ` Paul Walmsley
2012-04-11 18:26   ` Felipe Balbi
2012-04-11 18:26     ` Felipe Balbi
     [not found]     ` <20120411182634.GA9396-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-11 19:01       ` Paul Walmsley
2012-04-11 19:01         ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 05/12] ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 06/12] ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 07/12] ARM: OMAP: OCM RAM: use memset_io() when clearing SRAM Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 08/12] ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 09/12] ARM: OMAP: USB: remove unnecessary sideways include Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  0:35 ` [PATCH v4 10/12] ARM: OMAP1: board files: deduplicate and clean some NAND-related code Paul Walmsley
2012-04-11  0:35   ` Paul Walmsley
2012-04-11  9:12   ` Arnd Bergmann
2012-04-11  9:12     ` Arnd Bergmann
2012-04-11 18:45     ` Paul Walmsley
2012-04-11 18:45       ` Paul Walmsley
2012-04-11  0:36 ` [PATCH v4 11/12] ARM: OMAP1: DMTIMER: fix broken timer clock source selection Paul Walmsley
2012-04-11  0:36   ` Paul Walmsley
2012-04-17 21:48   ` Tony Lindgren
2012-04-17 21:48     ` Tony Lindgren
2012-04-17 21:53     ` Paul Walmsley
2012-04-17 21:53       ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F853788.2030007@antcom.de \
    --to=stigge@antcom.de \
    --cc=balbi@ti.com \
    --cc=gadiyar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.