From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm: vmscan: Do not stall on writeback during memory compaction
Date: Wed, 11 Apr 2012 13:26:13 -0400 [thread overview]
Message-ID: <4F85BEB5.6080702@redhat.com> (raw)
In-Reply-To: <1334162298-18942-3-git-send-email-mgorman@suse.de>
On 04/11/2012 12:38 PM, Mel Gorman wrote:
> This patch stops reclaim/compaction entering sync reclaim as this was only
> intended for lumpy reclaim and an oversight. Page migration has its own
> logic for stalling on writeback pages if necessary and memory compaction
> is already using it.
>
> Waiting on page writeback is bad for a number of reasons but the primary
> one is that waiting on writeback to a slow device like USB can take a
> considerable length of time. Page reclaim instead uses wait_iff_congested()
> to throttle if too many dirty pages are being scanned.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm: vmscan: Do not stall on writeback during memory compaction
Date: Wed, 11 Apr 2012 13:26:13 -0400 [thread overview]
Message-ID: <4F85BEB5.6080702@redhat.com> (raw)
In-Reply-To: <1334162298-18942-3-git-send-email-mgorman@suse.de>
On 04/11/2012 12:38 PM, Mel Gorman wrote:
> This patch stops reclaim/compaction entering sync reclaim as this was only
> intended for lumpy reclaim and an oversight. Page migration has its own
> logic for stalling on writeback pages if necessary and memory compaction
> is already using it.
>
> Waiting on page writeback is bad for a number of reasons but the primary
> one is that waiting on writeback to a slow device like USB can take a
> considerable length of time. Page reclaim instead uses wait_iff_congested()
> to throttle if too many dirty pages are being scanned.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2012-04-11 18:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 16:38 [PATCH 0/3] Removal of lumpy reclaim V2 Mel Gorman
2012-04-11 16:38 ` Mel Gorman
2012-04-11 16:38 ` [PATCH 1/3] mm: vmscan: Remove lumpy reclaim Mel Gorman
2012-04-11 16:38 ` Mel Gorman
2012-04-11 17:25 ` Rik van Riel
2012-04-11 17:25 ` Rik van Riel
2012-04-11 18:54 ` KOSAKI Motohiro
2012-04-11 18:54 ` KOSAKI Motohiro
2012-04-11 16:38 ` [PATCH 2/3] mm: vmscan: Do not stall on writeback during memory compaction Mel Gorman
2012-04-11 16:38 ` Mel Gorman
2012-04-11 17:26 ` Rik van Riel [this message]
2012-04-11 17:26 ` Rik van Riel
2012-04-11 18:51 ` KOSAKI Motohiro
2012-04-11 18:51 ` KOSAKI Motohiro
2012-04-11 16:38 ` [PATCH 3/3] mm: vmscan: Remove reclaim_mode_t Mel Gorman
2012-04-11 16:38 ` Mel Gorman
2012-04-11 17:26 ` Rik van Riel
2012-04-11 17:26 ` Rik van Riel
2012-04-11 19:48 ` KOSAKI Motohiro
2012-04-11 19:48 ` KOSAKI Motohiro
2012-04-11 17:17 ` [PATCH 0/3] Removal of lumpy reclaim V2 Rik van Riel
2012-04-11 17:17 ` Rik van Riel
2012-04-11 17:52 ` Mel Gorman
2012-04-11 17:52 ` Mel Gorman
2012-04-11 18:06 ` Rik van Riel
2012-04-11 18:06 ` Rik van Riel
2012-04-12 9:32 ` Mel Gorman
2012-04-12 9:32 ` Mel Gorman
2012-04-11 23:37 ` Ying Han
2012-04-11 23:37 ` Ying Han
2012-04-12 5:49 ` Mel Gorman
2012-04-12 5:49 ` Mel Gorman
2012-04-11 23:54 ` Hugh Dickins
2012-04-11 23:54 ` Hugh Dickins
2012-04-12 5:44 ` Mel Gorman
2012-04-12 5:44 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85BEB5.6080702@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.