From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers
Date: Fri, 13 Apr 2012 10:08:39 -0600 [thread overview]
Message-ID: <4F884F87.8000205@wwwdotorg.org> (raw)
In-Reply-To: <3d7a76d17b4366e08b45d528a245147095bbcb10.1334207964.git.viresh.kumar@st.com>
On 04/11/2012 11:24 PM, Viresh Kumar wrote:
> This adds pinctrl driver for SPEAr platform. It also updates MAINTAINERS file
> for SPEAr pinctrl drivers.
> +int __devinit spear_pinctrl_probe(struct platform_device *pdev,
> + struct spear_pinctrl_machdata *machdata)
...
> + pmx->vbase = of_iomap(np, 0);
...
> +}
> +
> +int __devexit spear_pinctrl_remove(struct platform_device *pdev)
> +{
> + struct spear_pmx *pmx = platform_get_drvdata(pdev);
> +
> + pinctrl_unregister(pmx->pctl);
> +
> + return 0;
> +}
of_iomap isn't a devm function, so youo need to unmap in remove(), and
in probe()'s error paths.
Or of course, you could just implement devm_of_iomap(); it's probably
very simple to do.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: devicetree-discuss@ozlabs.org, arnd@arndb.de,
linus.walleij@linaro.org, spear-devel@list.st.com,
viresh.linux@gmail.com, olof@lixom.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers
Date: Fri, 13 Apr 2012 10:08:39 -0600 [thread overview]
Message-ID: <4F884F87.8000205@wwwdotorg.org> (raw)
In-Reply-To: <3d7a76d17b4366e08b45d528a245147095bbcb10.1334207964.git.viresh.kumar@st.com>
On 04/11/2012 11:24 PM, Viresh Kumar wrote:
> This adds pinctrl driver for SPEAr platform. It also updates MAINTAINERS file
> for SPEAr pinctrl drivers.
> +int __devinit spear_pinctrl_probe(struct platform_device *pdev,
> + struct spear_pinctrl_machdata *machdata)
...
> + pmx->vbase = of_iomap(np, 0);
...
> +}
> +
> +int __devexit spear_pinctrl_remove(struct platform_device *pdev)
> +{
> + struct spear_pmx *pmx = platform_get_drvdata(pdev);
> +
> + pinctrl_unregister(pmx->pctl);
> +
> + return 0;
> +}
of_iomap isn't a devm function, so youo need to unmap in remove(), and
in probe()'s error paths.
Or of course, you could just implement devm_of_iomap(); it's probably
very simple to do.
next prev parent reply other threads:[~2012-04-13 16:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 5:24 [PATCH V3 0/4] pinctrl: Add SPEAr pinctrl support Viresh Kumar
2012-04-12 5:24 ` Viresh Kumar
2012-04-12 5:24 ` [PATCH V3 1/4] SPEAr: Remove existing padmux support for SPEAr Viresh Kumar
2012-04-12 5:24 ` Viresh Kumar
2012-04-13 13:00 ` Linus Walleij
2012-04-13 13:00 ` Linus Walleij
2012-04-12 5:24 ` [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers Viresh Kumar
2012-04-12 5:24 ` Viresh Kumar
2012-04-13 13:01 ` Linus Walleij
2012-04-13 13:01 ` Linus Walleij
2012-04-13 16:08 ` Stephen Warren [this message]
2012-04-13 16:08 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
2012-04-16 3:35 ` Viresh Kumar
2012-04-12 5:24 ` [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards Viresh Kumar
2012-04-12 5:24 ` Viresh Kumar
2012-04-13 13:05 ` Linus Walleij
2012-04-13 13:05 ` Linus Walleij
2012-04-13 16:18 ` Stephen Warren
2012-04-13 16:18 ` Stephen Warren
2012-04-16 3:37 ` Viresh Kumar
2012-04-16 3:37 ` Viresh Kumar
2012-04-16 18:05 ` Stephen Warren
2012-04-16 18:05 ` Stephen Warren
[not found] ` <4F8C5F68.7070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-16 18:08 ` viresh kumar
[not found] ` <61fe5fe87fdddfc66d21d82b1039de3782b50201.1334207964.git.viresh.kumar@st.com>
2012-04-13 13:04 ` [PATCH V3 3/4] pinctrl: Add SPEAr3xx pinctrl drivers Linus Walleij
2012-04-13 13:04 ` Linus Walleij
2012-04-13 16:13 ` Stephen Warren
2012-04-13 16:13 ` Stephen Warren
2012-04-16 3:35 ` Viresh Kumar
2012-04-16 3:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F884F87.8000205@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.