* [PATCH] Makefile: Some updates to uninstall
@ 2012-04-16 11:45 Fabio Fantoni
2012-04-16 12:08 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Fantoni @ 2012-04-16 11:45 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 2487 bytes --]
# HG changeset patch
# User Fabio Fantoni
# Date 1334565174 -7200
# Node ID a9c00a9b48c708a8e448bf5d9cd96026721fbf2f
# Parent 6b72eb3b40cf2b3d5a6c75d68fa7093c57fc0d1f
Makefile: Some updates to uninstall
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
diff -r 6b72eb3b40cf -r a9c00a9b48c7 Makefile
--- a/Makefile ven apr 13 17:13:01 2012 +0100
+++ b/Makefile lun apr 16 10:32:54 2012 +0200
@@ -220,13 +220,12 @@
uninstall: D=$(DESTDIR)
uninstall:
[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR)
$(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
- rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xen*
rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
rm -f $(D)$(SYSCONFIG_DIR)/xendomains
+ rm -f $(D)$(SYSCONFIG_DIR)/xencommons
rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
rm -rf $(D)/boot/*xen*
rm -rf $(D)/lib/modules/*xen*
@@ -236,11 +235,16 @@
rm -rf $(D)$(BINDIR)/pygrub
rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
rm -rf $(D)$(BINDIR)/xsls
- rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+ rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+ rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+ rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+ rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
rm -rf $(D)$(INCLUDEDIR)/xen
+ rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+ rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
- rm -rf $(D)$(LIBDIR)/libxenstore*
+ rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
rm -rf $(D)$(LIBDIR)/xen/
rm -rf $(D)$(LIBEXEC)/xen*
@@ -248,6 +252,7 @@
rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
rm -rf $(D)$(SHAREDIR)/doc/xen
rm -rf $(D)$(SHAREDIR)/xen
+ rm -rf $(D)$(SHAREDIR)/qemu-xen
rm -rf $(D)$(MAN1DIR)/xen*
rm -rf $(D)$(MAN8DIR)/xen*
rm -rf $(D)/boot/tboot*
[-- Attachment #1.1.2: make_uninstall_updates.patch --]
[-- Type: text/plain, Size: 2338 bytes --]
# HG changeset patch
# User Fabio Fantoni
# Date 1334565174 -7200
# Node ID a9c00a9b48c708a8e448bf5d9cd96026721fbf2f
# Parent 6b72eb3b40cf2b3d5a6c75d68fa7093c57fc0d1f
Makefile: Some updates to uninstall
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
diff -r 6b72eb3b40cf -r a9c00a9b48c7 Makefile
--- a/Makefile ven apr 13 17:13:01 2012 +0100
+++ b/Makefile lun apr 16 10:32:54 2012 +0200
@@ -220,13 +220,12 @@
uninstall: D=$(DESTDIR)
uninstall:
[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
- rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xen*
rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
rm -f $(D)$(SYSCONFIG_DIR)/xendomains
+ rm -f $(D)$(SYSCONFIG_DIR)/xencommons
rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
rm -rf $(D)/boot/*xen*
rm -rf $(D)/lib/modules/*xen*
@@ -236,11 +235,16 @@
rm -rf $(D)$(BINDIR)/pygrub
rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
rm -rf $(D)$(BINDIR)/xsls
- rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+ rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+ rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+ rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+ rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
rm -rf $(D)$(INCLUDEDIR)/xen
+ rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+ rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
- rm -rf $(D)$(LIBDIR)/libxenstore*
+ rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
rm -rf $(D)$(LIBDIR)/xen/
rm -rf $(D)$(LIBEXEC)/xen*
@@ -248,6 +252,7 @@
rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
rm -rf $(D)$(SHAREDIR)/doc/xen
rm -rf $(D)$(SHAREDIR)/xen
+ rm -rf $(D)$(SHAREDIR)/qemu-xen
rm -rf $(D)$(MAN1DIR)/xen*
rm -rf $(D)$(MAN8DIR)/xen*
rm -rf $(D)/boot/tboot*
[-- Attachment #1.2: Firma crittografica S/MIME --]
[-- Type: application/pkcs7-signature, Size: 4497 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Some updates to uninstall
2012-04-16 11:45 [PATCH] Makefile: Some updates to uninstall Fabio Fantoni
@ 2012-04-16 12:08 ` Ian Campbell
2012-04-17 14:30 ` Fantu
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2012-04-16 12:08 UTC (permalink / raw)
To: fantonifabio@tiscali.it; +Cc: xen-devel
On Mon, 2012-04-16 at 12:45 +0100, Fabio Fantoni wrote:
> # HG changeset patch
> # User Fabio Fantoni
> # Date 1334565174 -7200
> # Node ID a9c00a9b48c708a8e448bf5d9cd96026721fbf2f
> # Parent 6b72eb3b40cf2b3d5a6c75d68fa7093c57fc0d1f
> Makefile: Some updates to uninstall
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
>
> diff -r 6b72eb3b40cf -r a9c00a9b48c7 Makefile
> --- a/Makefile ven apr 13 17:13:01 2012 +0100
> +++ b/Makefile lun apr 16 10:32:54 2012 +0200
> @@ -220,13 +220,12 @@
> uninstall: D=$(DESTDIR)
> uninstall:
> [ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR)
> $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
> - rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
> + rm -rf $(D)$(CONFIG_DIR)/init.d/xen*
I know this is pre-existing but I'd rather see these enumerating all the
actual possibilities without wildcards, so as to not remove any local
initscripts which might happen to match (which becomes move likely with
your removal of the "d")
> rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
> - rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
> - rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
These two are things older versions of Xen installed but which current
versions do not?
> rm -f $(D)$(SYSCONFIG_DIR)/xendomains
> + rm -f $(D)$(SYSCONFIG_DIR)/xencommons
> rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
> rm -rf $(D)/boot/*xen*
> rm -rf $(D)/lib/modules/*xen*
> @@ -236,11 +235,16 @@
> rm -rf $(D)$(BINDIR)/pygrub
> rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
> rm -rf $(D)$(BINDIR)/xsls
> - rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
> + rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
> + rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
> + rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
> + rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
> rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
> rm -rf $(D)$(INCLUDEDIR)/xen
> + rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
> + rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
> rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
> - rm -rf $(D)$(LIBDIR)/libxenstore*
> + rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
> rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
> rm -rf $(D)$(LIBDIR)/xen/
> rm -rf $(D)$(LIBEXEC)/xen*
> @@ -248,6 +252,7 @@
> rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
> rm -rf $(D)$(SHAREDIR)/doc/xen
> rm -rf $(D)$(SHAREDIR)/xen
> + rm -rf $(D)$(SHAREDIR)/qemu-xen
> rm -rf $(D)$(MAN1DIR)/xen*
> rm -rf $(D)$(MAN8DIR)/xen*
> rm -rf $(D)/boot/tboot*
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Some updates to uninstall
2012-04-16 12:08 ` Ian Campbell
@ 2012-04-17 14:30 ` Fantu
2012-04-17 14:38 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Fantu @ 2012-04-17 14:30 UTC (permalink / raw)
To: xen-devel
Ian Campbell-10 wrote
>
>> rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
>> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
>> - rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
>> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
>> - rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
>
> These two are things older versions of Xen installed but which current
> versions do not?
>
I not understand that.
Could you clarify me?
--
View this message in context: http://xen.1045712.n5.nabble.com/PATCH-Makefile-Some-updates-to-uninstall-tp5643579p5646707.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: Some updates to uninstall
2012-04-17 14:30 ` Fantu
@ 2012-04-17 14:38 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2012-04-17 14:38 UTC (permalink / raw)
To: Fantu; +Cc: xen-devel@lists.xensource.com
On Tue, 2012-04-17 at 15:30 +0100, Fantu wrote:
> Ian Campbell-10 wrote
> >
> >> rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
> >> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
> >> - rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
> >> rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
> >> - rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
> >
> > These two are things older versions of Xen installed but which current
> > versions do not?
> >
> I not understand that.
> Could you clarify me?
Why are we deleting them now (before your patch), where did they used to
come from? If we no longer create them then it is fine (IMHO) to stop
removing them.
>
> --
> View this message in context: http://xen.1045712.n5.nabble.com/PATCH-Makefile-Some-updates-to-uninstall-tp5643579p5646707.html
> Sent from the Xen - Dev mailing list archive at Nabble.com.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-17 14:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-16 11:45 [PATCH] Makefile: Some updates to uninstall Fabio Fantoni
2012-04-16 12:08 ` Ian Campbell
2012-04-17 14:30 ` Fantu
2012-04-17 14:38 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.