From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver
Date: Mon, 16 Apr 2012 17:52:08 +0200 [thread overview]
Message-ID: <4F8C4028.5090602@antcom.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204161106410.1408-100000@iolanthe.rowland.org>
On 04/16/2012 05:09 PM, Alan Stern wrote:
>> drivers/usb/Makefile | 5 ++
>> drivers/usb/misc/Kconfig | 12 ++++++
>> drivers/usb/misc/Makefile | 1
>> drivers/usb/misc/isp1301.c | 64 ++++++++++++++++++++++++++++++++++
>> include/linux/usb/isp1301.h | 82 ++++++++++++++++++++++++++++++++++++++++++++
>
> You know, drivers/usb/misc is meant for miscellaneous USB device
> drivers. Not for host or transceiver drivers.
>
> You should put the new file somewhere else. Maybe in the otg
> directory, although that may not be completely appropriate either.
> Maybe something under the host directory.
The driver is used by drivers in the following directories:
drivers/usb/host/ (ohci-nxp.c)
drivers/usb/otg/ (isp1301_omap.c)
drivers/usb/gadget/ (lpc32xx_udc.c)
So host/ and otg/ don't look much better.
Maybe one of (new):
drivers/usb/transceiver/
drivers/usb/phy/
drivers/usb/lowlevel/
?
Otherwise, I will put it in drivers/usb/otg/ even of it doesn't look
better to me but the chip is advertised as "OTG transceiver". ;-)
Thanks in advance,
Roland
WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver
Date: Mon, 16 Apr 2012 17:52:08 +0200 [thread overview]
Message-ID: <4F8C4028.5090602@antcom.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204161106410.1408-100000@iolanthe.rowland.org>
On 04/16/2012 05:09 PM, Alan Stern wrote:
>> drivers/usb/Makefile | 5 ++
>> drivers/usb/misc/Kconfig | 12 ++++++
>> drivers/usb/misc/Makefile | 1
>> drivers/usb/misc/isp1301.c | 64 ++++++++++++++++++++++++++++++++++
>> include/linux/usb/isp1301.h | 82 ++++++++++++++++++++++++++++++++++++++++++++
>
> You know, drivers/usb/misc is meant for miscellaneous USB device
> drivers. Not for host or transceiver drivers.
>
> You should put the new file somewhere else. Maybe in the otg
> directory, although that may not be completely appropriate either.
> Maybe something under the host directory.
The driver is used by drivers in the following directories:
drivers/usb/host/ (ohci-nxp.c)
drivers/usb/otg/ (isp1301_omap.c)
drivers/usb/gadget/ (lpc32xx_udc.c)
So host/ and otg/ don't look much better.
Maybe one of (new):
drivers/usb/transceiver/
drivers/usb/phy/
drivers/usb/lowlevel/
?
Otherwise, I will put it in drivers/usb/otg/ even of it doesn't look
better to me but the chip is advertised as "OTG transceiver". ;-)
Thanks in advance,
Roland
next prev parent reply other threads:[~2012-04-16 15:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 13:16 [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver Roland Stigge
2012-04-16 13:16 ` Roland Stigge
2012-04-16 13:16 ` [PATCH v2 2/3] USB: gadget driver for LPC32xx Roland Stigge
2012-04-16 13:16 ` Roland Stigge
2012-04-16 13:16 ` [PATCH v2 3/3] USB: ohci-nxp: Use isp1301 driver Roland Stigge
2012-04-16 13:16 ` Roland Stigge
2012-04-16 14:14 ` [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver Arnd Bergmann
2012-04-16 14:14 ` Arnd Bergmann
2012-04-16 15:40 ` Roland Stigge
2012-04-16 15:40 ` Roland Stigge
2012-04-16 15:09 ` Alan Stern
2012-04-16 15:09 ` Alan Stern
2012-04-16 15:52 ` Roland Stigge [this message]
2012-04-16 15:52 ` Roland Stigge
2012-04-16 15:58 ` Greg KH
2012-04-16 15:58 ` Greg KH
2012-04-16 16:02 ` Alan Stern
2012-04-16 16:02 ` Alan Stern
2012-04-16 16:12 ` Roland Stigge
2012-04-16 16:12 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C4028.5090602@antcom.de \
--to=stigge@antcom.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.