From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] mac80211: Support on-channel scan option.
Date: Mon, 16 Apr 2012 10:33:00 -0700 [thread overview]
Message-ID: <4F8C57CC.4090505@sipsolutions.net> (raw)
In-Reply-To: <1334248689-23018-1-git-send-email-greearb@candelatech.com> (sfid-20120412_183929_638765_C70D881D)
Did you test it?
> + /* If we are scanning only on the current channel, then
> + * we do not need to stop normal activities
> + */
> + unsigned long next_delay;
> +
> + __set_bit(SCAN_ONCHANNEL_SCANNING,&local->scanning);
> + ieee80211_recalc_idle(local);
> + /* Notify driver scan is starting, keep order of operations
> + * same as normal software scan, in case that matters. */
> + drv_sw_scan_start(local);
> + ieee80211_configure_filter(local); /* accept probe-responses */
> + /* We need to ensure power level is at max for scanning. */
> + ieee80211_hw_config(local, 0);
a few blank lines would be nice :)
> + if ((req->channels[0]->flags&
> + IEEE80211_CHAN_PASSIVE_SCAN) ||
> + !local->scan_req->n_ssids) {
That formatting is a bit off it seems. Or is that just my mailer?
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] mac80211: Support on-channel scan option.
Date: Mon, 16 Apr 2012 10:33:00 -0700 [thread overview]
Message-ID: <4F8C57CC.4090505@sipsolutions.net> (raw)
In-Reply-To: <1334248689-23018-1-git-send-email-greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org> (sfid-20120412_183929_638765_C70D881D)
Did you test it?
> + /* If we are scanning only on the current channel, then
> + * we do not need to stop normal activities
> + */
> + unsigned long next_delay;
> +
> + __set_bit(SCAN_ONCHANNEL_SCANNING,&local->scanning);
> + ieee80211_recalc_idle(local);
> + /* Notify driver scan is starting, keep order of operations
> + * same as normal software scan, in case that matters. */
> + drv_sw_scan_start(local);
> + ieee80211_configure_filter(local); /* accept probe-responses */
> + /* We need to ensure power level is at max for scanning. */
> + ieee80211_hw_config(local, 0);
a few blank lines would be nice :)
> + if ((req->channels[0]->flags&
> + IEEE80211_CHAN_PASSIVE_SCAN) ||
> + !local->scan_req->n_ssids) {
That formatting is a bit off it seems. Or is that just my mailer?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-16 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 16:38 [PATCH v3] mac80211: Support on-channel scan option greearb
2012-04-16 17:33 ` Johannes Berg [this message]
2012-04-16 17:33 ` Johannes Berg
2012-04-16 17:41 ` Ben Greear
2012-04-16 17:41 ` Ben Greear
2012-04-16 18:03 ` Adrian Chadd
2012-04-16 18:03 ` Adrian Chadd
2012-04-16 19:58 ` Johannes Berg
2012-04-16 19:58 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C57CC.4090505@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.