From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 3/5] pinctrl: Add SPEAr pinctrl drivers
Date: Tue, 17 Apr 2012 14:02:08 +0530 [thread overview]
Message-ID: <4F8D2A88.6060309@st.com> (raw)
In-Reply-To: <f9cc539f87a9c73546fe6671d55d86838886adce.1334548272.git.viresh.kumar@st.com>
On 4/16/2012 9:43 AM, Viresh KUMAR wrote:
> diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
>
> +int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> + struct device_node *np_config,
> + struct pinctrl_map **map, unsigned *num_maps)
> +{
> +
> + *map = kzalloc(sizeof(*map) * count, GFP_KERNEL);
> + if (!*map)
> + return -ENOMEM;
> +
Linus,
This was the place that caused crash for me.
I would apply following change in my patch before sending pull request
to Arnd.
- *map = kzalloc(sizeof(*map) * count, GFP_KERNEL);
+ *map = kzalloc(sizeof(**map) * count, GFP_KERNEL);
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
To: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: Viresh KUMAR <viresh.kumar-qxv4g6HH51o@public.gmane.org>,
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org,
viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V4 3/5] pinctrl: Add SPEAr pinctrl drivers
Date: Tue, 17 Apr 2012 14:02:08 +0530 [thread overview]
Message-ID: <4F8D2A88.6060309@st.com> (raw)
In-Reply-To: <f9cc539f87a9c73546fe6671d55d86838886adce.1334548272.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
On 4/16/2012 9:43 AM, Viresh KUMAR wrote:
> diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
>
> +int spear_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
> + struct device_node *np_config,
> + struct pinctrl_map **map, unsigned *num_maps)
> +{
> +
> + *map = kzalloc(sizeof(*map) * count, GFP_KERNEL);
> + if (!*map)
> + return -ENOMEM;
> +
Linus,
This was the place that caused crash for me.
I would apply following change in my patch before sending pull request
to Arnd.
- *map = kzalloc(sizeof(*map) * count, GFP_KERNEL);
+ *map = kzalloc(sizeof(**map) * count, GFP_KERNEL);
--
viresh
next prev parent reply other threads:[~2012-04-17 8:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 4:13 [PATCH V4 0/5] pinctrl: Add SPEAr pinctrl support Viresh Kumar
2012-04-16 4:13 ` Viresh Kumar
2012-04-16 4:13 ` [PATCH V4 1/5] of: Implement managed of_iomap() Viresh Kumar
2012-04-16 4:13 ` Viresh Kumar
2012-04-16 9:27 ` Linus Walleij
2012-04-16 9:27 ` Linus Walleij
2012-04-16 14:42 ` Arnd Bergmann
2012-04-16 14:42 ` Arnd Bergmann
2012-04-16 15:06 ` Grant Likely
2012-04-16 15:06 ` Grant Likely
2012-04-16 15:12 ` viresh kumar
2012-04-16 15:19 ` Grant Likely
2012-04-16 15:19 ` Grant Likely
2012-04-16 16:21 ` viresh kumar
2012-04-16 16:21 ` viresh kumar
2012-04-16 17:06 ` Grant Likely
2012-04-16 17:06 ` Grant Likely
[not found] ` <CACxGe6t9+M5jQKkRduup7_wk4SKYu1SuTz7wzf0MEvo0poojRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-16 17:10 ` viresh kumar
2012-04-16 17:33 ` Sergei Shtylyov
2012-04-16 17:33 ` Sergei Shtylyov
2012-04-16 4:13 ` [PATCH V4 2/5] SPEAr: Remove existing padmux support for SPEAr Viresh Kumar
2012-04-16 4:13 ` Viresh Kumar
2012-04-16 4:13 ` [PATCH V4 3/5] pinctrl: Add SPEAr pinctrl drivers Viresh Kumar
2012-04-16 4:13 ` Viresh Kumar
2012-04-17 8:32 ` Viresh Kumar [this message]
2012-04-17 8:32 ` Viresh Kumar
2012-04-18 11:24 ` Linus Walleij
2012-04-18 11:24 ` Linus Walleij
2012-04-16 4:14 ` [PATCH V4 5/5] SPEAr3xx: Add pinctrl support for boards Viresh Kumar
2012-04-16 4:14 ` Viresh Kumar
2012-04-16 9:29 ` [PATCH V4 0/5] pinctrl: Add SPEAr pinctrl support Linus Walleij
2012-04-16 9:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8D2A88.6060309@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.