From: Jan Ceuleers <jan.ceuleers@computer.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] net: filter: Just In Time compiler for sparc
Date: Tue, 17 Apr 2012 17:02:22 +0000 [thread overview]
Message-ID: <4F8DA21E.9020809@computer.org> (raw)
In-Reply-To: <20120416.225823.1395194623649559124.davem@davemloft.net>
David Miller wrote:
>
> Signed-off-by: David S. Miller<davem@davemloft.net>
> ---
>
> I think I'll commit this to net-next so it's easier to track
> any BPF changes we make there.
I hate to nitpick; see below.
> + bl bpf_slow_path_word_neg
> + nop
> + .globl bpf_jit_load_word_positive_offset
> +bpf_jit_load_word_positive_offset:
> + sub r_HEADLEN, r_OFF, r_TMP
> + cmp r_TMP, 3
> + ble bpf_slow_path_word
> + add r_SKB_DATA, r_OFF, r_TMP
> + andcc r_TMP, 3, %g0
> + bne load_word_unaligned
> + nop
> + retl
> + ld [r_SKB_DATA + r_OFF], r_A
There is inconsistent spacing in multiple places; a few examples shown
above.
KR, Jan
WARNING: multiple messages have this Message-ID (diff)
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] net: filter: Just In Time compiler for sparc
Date: Tue, 17 Apr 2012 19:02:22 +0200 [thread overview]
Message-ID: <4F8DA21E.9020809@computer.org> (raw)
In-Reply-To: <20120416.225823.1395194623649559124.davem@davemloft.net>
David Miller wrote:
>
> Signed-off-by: David S. Miller<davem@davemloft.net>
> ---
>
> I think I'll commit this to net-next so it's easier to track
> any BPF changes we make there.
I hate to nitpick; see below.
> + bl bpf_slow_path_word_neg
> + nop
> + .globl bpf_jit_load_word_positive_offset
> +bpf_jit_load_word_positive_offset:
> + sub r_HEADLEN, r_OFF, r_TMP
> + cmp r_TMP, 3
> + ble bpf_slow_path_word
> + add r_SKB_DATA, r_OFF, r_TMP
> + andcc r_TMP, 3, %g0
> + bne load_word_unaligned
> + nop
> + retl
> + ld [r_SKB_DATA + r_OFF], r_A
There is inconsistent spacing in multiple places; a few examples shown
above.
KR, Jan
next prev parent reply other threads:[~2012-04-17 17:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 2:58 [PATCH] net: filter: Just In Time compiler for sparc David Miller
2012-04-17 2:58 ` David Miller
2012-04-17 17:02 ` Jan Ceuleers [this message]
2012-04-17 17:02 ` Jan Ceuleers
2012-04-17 17:23 ` Eric Dumazet
2012-04-17 17:23 ` Eric Dumazet
2012-04-17 19:42 ` David Miller
2012-04-17 19:42 ` David Miller
2012-04-18 16:39 ` Jan Ceuleers
2012-04-18 16:39 ` Jan Ceuleers
2012-04-17 18:59 ` Richard Mortimer
2012-04-17 18:59 ` Richard Mortimer
2012-04-17 20:15 ` David Miller
2012-04-17 20:15 ` David Miller
2012-04-17 19:57 ` Sam Ravnborg
2012-04-17 19:57 ` Sam Ravnborg
2012-04-17 20:44 ` David Miller
2012-04-17 20:44 ` David Miller
2012-04-19 15:29 ` Sam Ravnborg
2012-04-19 15:29 ` Sam Ravnborg
2012-04-19 17:47 ` David Miller
2012-04-19 17:47 ` David Miller
2012-04-17 20:59 ` Leif Sawyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8DA21E.9020809@computer.org \
--to=jan.ceuleers@computer.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.