From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
To: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
Date: Tue, 17 Apr 2012 11:29:27 -0700 [thread overview]
Message-ID: <4F8DB687.2090701@xenotime.net> (raw)
In-Reply-To: <1334640620.27247.7.camel@cumari>
On 04/16/2012 10:30 PM, Luciano Coelho wrote:
> Hi Randy,
>
> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
>
> [...]
>
>> Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
>> Cc: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org>
>> Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Cc: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>> ---
>
> Thanks for the patch!
>
>
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
>> @@ -1,5 +1,6 @@
>> config WL12XX
>> tristate "TI wl12xx support"
>> + depends on MAC80211
>> select WLCORE
>
> Do we really need this one? wl12xx selects WLCORE which in turn depends
> on MAC80211 (with your change below). Maybe we don't need this?
Hi,
[testing...]
The build fails if either one of these "depends" is omitted.
>> ---help---
>> This module adds support for wireless adapters based on TI wl1271,
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
>> @@ -1,6 +1,6 @@
>> config WLCORE
>> tristate "TI wlcore support"
>> - depends on WL_TI && GENERIC_HARDIRQS
>> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>> depends on INET
>> select FW_LOADER
>> ---help---
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@xenotime.net>
To: Luciano Coelho <coelho@ti.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211
Date: Tue, 17 Apr 2012 11:29:27 -0700 [thread overview]
Message-ID: <4F8DB687.2090701@xenotime.net> (raw)
In-Reply-To: <1334640620.27247.7.camel@cumari>
On 04/16/2012 10:30 PM, Luciano Coelho wrote:
> Hi Randy,
>
> On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> wl12xx build fails with many undefined symbol errors when MAC80211
>> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
>> on MAC80211 (which already depends on CFG80211).
>>
>> Here are a few of the many build errors:
>>
>
> [...]
>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: Luciano Coelho <coelho@ti.com>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: "John W. Linville" <linville@tuxdriver.com>
>> ---
>
> Thanks for the patch!
>
>
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
>> @@ -1,5 +1,6 @@
>> config WL12XX
>> tristate "TI wl12xx support"
>> + depends on MAC80211
>> select WLCORE
>
> Do we really need this one? wl12xx selects WLCORE which in turn depends
> on MAC80211 (with your change below). Maybe we don't need this?
Hi,
[testing...]
The build fails if either one of these "depends" is omitted.
>> ---help---
>> This module adds support for wireless adapters based on TI wl1271,
>> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
>> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
>> @@ -1,6 +1,6 @@
>> config WLCORE
>> tristate "TI wlcore support"
>> - depends on WL_TI && GENERIC_HARDIRQS
>> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>> depends on INET
>> select FW_LOADER
>> ---help---
>
--
~Randy
next prev parent reply other threads:[~2012-04-17 18:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 19:50 ` Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
2012-04-16 22:20 ` Paul Gortmaker
2012-04-17 1:25 ` Randy Dunlap
2012-04-17 1:25 ` Randy Dunlap
2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
2012-04-17 5:30 ` Luciano Coelho
2012-04-17 18:29 ` Randy Dunlap [this message]
2012-04-17 18:29 ` Randy Dunlap
2012-04-17 15:52 ` Luciano Coelho
[not found] ` <4F8C784B.2040402-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-05-03 12:55 ` Luciano Coelho
2012-05-03 12:55 ` Luciano Coelho
2012-05-10 21:25 ` Randy Dunlap
2012-05-10 21:36 ` Luciano Coelho
2012-05-10 21:37 ` Randy Dunlap
2012-05-11 11:59 ` Arend van Spriel
2012-04-17 1:01 ` [PATCH -next] staging: fix android alarm.c printk format warnings Randy Dunlap
2012-04-17 1:01 ` [PATCH -next] soc: fix printk format in soc-dapm.c Randy Dunlap
2012-04-17 1:01 ` Randy Dunlap
2012-04-16 22:52 ` [alsa-devel] " Fabio Estevam
2012-04-17 1:01 ` [PATCH -next] hippi: fix printk format in rrunner.c Randy Dunlap
2012-04-17 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8DB687.2090701@xenotime.net \
--to=rdunlap-/uha2rfvqtnk1umjsbkqmq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=coelho-l0cyMroinI0@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.