Re: [RFCv1] mac80211: Adds Software / Virtual AMP 80211

[Johannes Berg <johannes@sipsolutions.net>]

On 4/18/2012 4:20 AM, Andrei Emeltchenko wrote:
> Hi Johannes,
>
> On Tue, Apr 17, 2012 at 07:07:21PM -0700, Johannes Berg wrote:
>>>>>>> I don't get this patch at all. Why am I reviewing some very very basic
>>>>>>> skeleton code when we should be discussing userspace APIs (we have
>>>>>>> already discussed them with a few people years ago), how the AMP is
>>>>>>> going to be managed, how the security handshake is going to work, etc.
>>>
>>> Do we have some outcome from that discussion?
>>
>> This API-defining patch is probably the best we have:
>> http://johannes.sipsolutions.net/patches/kernel/all/2010-10-13-15%
>> 3a24/035-bt3-amp.patch
>
> Thanks for the link. After looking to the patches I think that there are
> some similarities with respect to interface type. As I understood the
> basic idea is the same: create virtual interface. But in your case the
> implementation is really difficult.
>
> Why do we need netlink commands like NL80211_CMD_HCI_AMP_ADD and
> NL80211_CMD_HCI_AMP_DELETE if what we need is to create/delete virtual
> interface which can be done with standard tools with a several lines
> patch to iw:

[...]

That would work, but the plan was to have separate commands because 
those commands create a virtual netdev, which we don't want in this case.

And no, given the lack of userspace tools we never tested these patches. 
I was more of a "write down API thoughts in code" thing.

johannes