All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	linux-arm-kernel@lists.infradead.org, boojin.kim@samsung.com
Subject: Re: [PATCH 05/12] ARM: Exynos5: Add MDMA0 clock instance
Date: Wed, 18 Apr 2012 18:20:27 -0700	[thread overview]
Message-ID: <4F8F685B.3080006@samsung.com> (raw)
In-Reply-To: <1334641595-25301-6-git-send-email-thomas.abraham@linaro.org>

Thomas Abraham wrote:
> Add clock instance for MDMA0 controller.
> 
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
> ---
>   arch/arm/mach-exynos/clock-exynos5.c |   11 +++++++++--
>   1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> index fb95e9b..0230ba8 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -768,9 +768,14 @@ static struct clk exynos5_clk_pdma = {
>   	.ctrlbit	= (1<<  1),
>   };
> 
> +static struct clk exynos5_clk_mdma0 = {
> +	.name		= "dma",
> +	.enable		= exynos5_clk_ip_acp_ctrl,
> +	.ctrlbit	= (1<<  1),
> +};
> +
>   static struct clk exynos5_clk_mdma1 = {
>   	.name		= "dma",
> -	.devname	= "dma-pl330.2",
>   	.enable		= exynos5_clk_ip_gen_ctrl,
>   	.ctrlbit	= (1<<  4),
>   };
> @@ -1057,6 +1062,7 @@ static struct clksrc_clk *exynos5_sysclks[] = {
> 
>   static struct clk *exynos5_clk_cdev[] = {
>   	&exynos5_clk_pdma,
> +	&exynos5_clk_mdma0,
>   	&exynos5_clk_mdma1,
>   };
> 
> @@ -1082,7 +1088,8 @@ static struct clk_lookup exynos5_clk_lookup[] = {
>   	CLKDEV_INIT("exynos4-sdhci.3", "mmc_busclk.2",&exynos5_clk_sclk_mmc3.clk),
>   	CLKDEV_INIT("dma-pl330.0", "apb_pclk",&exynos5_clk_pdma),
>   	CLKDEV_INIT("dma-pl330.1", "apb_pclk",&exynos5_clk_pdma),
> -	CLKDEV_INIT("dma-pl330.2", "apb_pclk",&exynos5_clk_mdma1),
> +	CLKDEV_INIT("dma-pl330.2", "apb_pclk",&exynos5_clk_mdma0),
> +	CLKDEV_INIT("dma-pl330.3", "apb_pclk",&exynos5_clk_mdma1),
>   };
> 
>   static unsigned long exynos5_epll_get_rate(struct clk *clk)

Well, mdma0 will not be used so we don't need this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/12] ARM: Exynos5: Add MDMA0 clock instance
Date: Wed, 18 Apr 2012 18:20:27 -0700	[thread overview]
Message-ID: <4F8F685B.3080006@samsung.com> (raw)
In-Reply-To: <1334641595-25301-6-git-send-email-thomas.abraham@linaro.org>

Thomas Abraham wrote:
> Add clock instance for MDMA0 controller.
> 
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro.org>
> ---
>   arch/arm/mach-exynos/clock-exynos5.c |   11 +++++++++--
>   1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> index fb95e9b..0230ba8 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -768,9 +768,14 @@ static struct clk exynos5_clk_pdma = {
>   	.ctrlbit	= (1<<  1),
>   };
> 
> +static struct clk exynos5_clk_mdma0 = {
> +	.name		= "dma",
> +	.enable		= exynos5_clk_ip_acp_ctrl,
> +	.ctrlbit	= (1<<  1),
> +};
> +
>   static struct clk exynos5_clk_mdma1 = {
>   	.name		= "dma",
> -	.devname	= "dma-pl330.2",
>   	.enable		= exynos5_clk_ip_gen_ctrl,
>   	.ctrlbit	= (1<<  4),
>   };
> @@ -1057,6 +1062,7 @@ static struct clksrc_clk *exynos5_sysclks[] = {
> 
>   static struct clk *exynos5_clk_cdev[] = {
>   	&exynos5_clk_pdma,
> +	&exynos5_clk_mdma0,
>   	&exynos5_clk_mdma1,
>   };
> 
> @@ -1082,7 +1088,8 @@ static struct clk_lookup exynos5_clk_lookup[] = {
>   	CLKDEV_INIT("exynos4-sdhci.3", "mmc_busclk.2",&exynos5_clk_sclk_mmc3.clk),
>   	CLKDEV_INIT("dma-pl330.0", "apb_pclk",&exynos5_clk_pdma),
>   	CLKDEV_INIT("dma-pl330.1", "apb_pclk",&exynos5_clk_pdma),
> -	CLKDEV_INIT("dma-pl330.2", "apb_pclk",&exynos5_clk_mdma1),
> +	CLKDEV_INIT("dma-pl330.2", "apb_pclk",&exynos5_clk_mdma0),
> +	CLKDEV_INIT("dma-pl330.3", "apb_pclk",&exynos5_clk_mdma1),
>   };
> 
>   static unsigned long exynos5_epll_get_rate(struct clk *clk)

Well, mdma0 will not be used so we don't need this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2012-04-19  1:20 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  5:46 [PATCH 00/12] Updates for Exynos5250 Rev1.0 and device tree support Thomas Abraham
2012-04-17  5:46 ` Thomas Abraham
2012-04-17  5:46 ` [PATCH 01/12] ARM: Exynos: Remove a new bus_type instance for Exynos5 Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  0:15   ` Kukjin Kim
2012-04-19  0:15     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  0:51   ` Kukjin Kim
2012-04-19  0:51     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 03/12] ARM: Exynos5: Add watchdog timer clock instance Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  6:14   ` Kyungmin Park
2012-04-17  6:14     ` Kyungmin Park
2012-04-17  8:12     ` Thomas Abraham
2012-04-17  8:12       ` Thomas Abraham
2012-04-19  0:28   ` Kukjin Kim
2012-04-19  0:28     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 04/12] ARM: Exynos5: Remove duplicated instantiation of pdma clock Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  0:30   ` Kukjin Kim
2012-04-19  0:30     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 05/12] ARM: Exynos5: Add MDMA0 clock instance Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  1:20   ` Kukjin Kim [this message]
2012-04-19  1:20     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 06/12] rtc-s3c: Fix breakage introduced by S3C2443/S3C2416 support Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  6:30   ` Kyungmin Park
2012-04-17  6:30     ` Kyungmin Park
2012-04-17  8:15     ` Thomas Abraham
2012-04-17  8:15       ` Thomas Abraham
2012-04-17  8:25       ` Kyungmin Park
2012-04-17  8:25         ` Kyungmin Park
2012-04-17  8:39         ` Thomas Abraham
2012-04-17  8:39           ` Thomas Abraham
2012-04-17  5:46 ` [PATCH 07/12] ARM: Exynos5: Modify the GIC physical address for static io-mapping Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  6:31   ` Kyungmin Park
2012-04-17  6:31     ` Kyungmin Park
2012-04-17  8:19     ` Thomas Abraham
2012-04-17  8:19       ` Thomas Abraham
2012-04-17  5:46 ` [PATCH 08/12] gpio/samsung: add GPC4 bank instance Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  6:33   ` Kyungmin Park
2012-04-17  6:33     ` Kyungmin Park
2012-04-17  8:24     ` Thomas Abraham
2012-04-17  8:24       ` Thomas Abraham
2012-04-19  0:36   ` Kukjin Kim
2012-04-19  0:36     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 09/12] ARM: Exynos5: Add pre-divider and fout mux clocks for bpll and mpll Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  5:46 ` [PATCH 10/12] ARM: Exynos: Redefine IRQ_MCT_L0,1 definition Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  1:00   ` Kukjin Kim
2012-04-19  1:00     ` Kukjin Kim
2012-04-17  5:46 ` [PATCH 11/12] ARM: Exynos5: Update device tree source files Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-17  5:46 ` [PATCH 12/12] ARM: Exynos5: Update device tree enabled machine file Thomas Abraham
2012-04-17  5:46   ` Thomas Abraham
2012-04-19  0:23   ` Kukjin Kim
2012-04-19  0:23     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8F685B.3080006@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=boojin.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.