From: Stephen Warren <swarren@wwwdotorg.org>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCHv2 1/2] drivers: input: keypad: Add device tree support
Date: Thu, 19 Apr 2012 09:23:49 -0600 [thread overview]
Message-ID: <4F902E05.30503@wwwdotorg.org> (raw)
In-Reply-To: <1334848537-823-1-git-send-email-sourav.poddar@ti.com>
On 04/19/2012 09:15 AM, Sourav Poddar wrote:
> Update the Documentation with omap4 keypad device tree
> binding information.
> Add device tree support for omap4 keypad driver.
>
> Tested on omap4430 sdp with 3.4-rc3.
> diff --git a/Documentation/devicetree/bindings/input/omap-keypad.txt b/Documentation/devicetree/bindings/input/omap-keypad.txt
> +- Keys represented as child nodes: Each key connected to the keypad
> + controller is represented as a child node to the keypad controller
> + device node and should include the following properties.
> + - keypad,row: the row number to which the key is connected.
> + - keypad,column: the column number to which the key is connected.
> + - linux,code: the key-code to be reported when the key is pressed
> + and released.
Shouldn't this use the common matrix keymap bindings;
Documentation/devicetree/bindings/input/matrix-keymap.txt
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/2] drivers: input: keypad: Add device tree support
Date: Thu, 19 Apr 2012 09:23:49 -0600 [thread overview]
Message-ID: <4F902E05.30503@wwwdotorg.org> (raw)
In-Reply-To: <1334848537-823-1-git-send-email-sourav.poddar@ti.com>
On 04/19/2012 09:15 AM, Sourav Poddar wrote:
> Update the Documentation with omap4 keypad device tree
> binding information.
> Add device tree support for omap4 keypad driver.
>
> Tested on omap4430 sdp with 3.4-rc3.
> diff --git a/Documentation/devicetree/bindings/input/omap-keypad.txt b/Documentation/devicetree/bindings/input/omap-keypad.txt
> +- Keys represented as child nodes: Each key connected to the keypad
> + controller is represented as a child node to the keypad controller
> + device node and should include the following properties.
> + - keypad,row: the row number to which the key is connected.
> + - keypad,column: the column number to which the key is connected.
> + - linux,code: the key-code to be reported when the key is pressed
> + and released.
Shouldn't this use the common matrix keymap bindings;
Documentation/devicetree/bindings/input/matrix-keymap.txt
next prev parent reply other threads:[~2012-04-19 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 15:15 [PATCHv2 1/2] drivers: input: keypad: Add device tree support Sourav Poddar
2012-04-19 15:15 ` Sourav Poddar
2012-04-19 15:15 ` Sourav Poddar
2012-04-19 15:15 ` [PATCHv2 2/2] arm/dts: omap4-sdp: Add keypad data Sourav Poddar
2012-04-19 15:15 ` Sourav Poddar
2012-04-19 15:15 ` Sourav Poddar
2012-04-19 15:23 ` Stephen Warren [this message]
2012-04-19 15:23 ` [PATCHv2 1/2] drivers: input: keypad: Add device tree support Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2012-04-19 15:17 Sourav Poddar
2012-04-19 15:17 ` Sourav Poddar
2012-04-19 15:17 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F902E05.30503@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.