* [PATCH v2] Makefile: Some updates to uninstall
@ 2012-04-23 8:42 Fabio Fantoni
2012-04-24 13:09 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Fantoni @ 2012-04-23 8:42 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 2614 bytes --]
# HG changeset patch
# User Fabio Fantoni
# Date 1335169615 -7200
# Node ID b3375cbe809eb8398b75cd2b1590b957134e01f8
# Parent 274e5accd62db09a7f703400c8720f7fdd95551a
Makefile: Some updates to uninstall
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
diff -r 274e5accd62d -r b3375cbe809e Makefile
--- a/Makefile ven apr 20 09:49:06 2012 +0100
+++ b/Makefile lun apr 23 10:26:55 2012 +0200
@@ -220,13 +220,13 @@
uninstall: D=$(DESTDIR)
uninstall:
[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR)
$(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
- rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains
$(D)$(CONFIG_DIR)/init.d/xend
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons
$(D)$(CONFIG_DIR)/init.d/xen-watchdog
rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
rm -f $(D)$(SYSCONFIG_DIR)/xendomains
+ rm -f $(D)$(SYSCONFIG_DIR)/xencommons
rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
rm -rf $(D)/boot/*xen*
rm -rf $(D)/lib/modules/*xen*
@@ -236,11 +236,16 @@
rm -rf $(D)$(BINDIR)/pygrub
rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
rm -rf $(D)$(BINDIR)/xsls
- rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+ rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+ rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+ rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+ rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
rm -rf $(D)$(INCLUDEDIR)/xen
+ rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+ rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
- rm -rf $(D)$(LIBDIR)/libxenstore*
+ rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
rm -rf $(D)$(LIBDIR)/xen/
rm -rf $(D)$(LIBEXEC)/xen*
@@ -248,6 +253,7 @@
rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
rm -rf $(D)$(SHAREDIR)/doc/xen
rm -rf $(D)$(SHAREDIR)/xen
+ rm -rf $(D)$(SHAREDIR)/qemu-xen
rm -rf $(D)$(MAN1DIR)/xen*
rm -rf $(D)$(MAN8DIR)/xen*
rm -rf $(D)/boot/tboot*
[-- Attachment #1.1.2: make_uninstall_updates.patch --]
[-- Type: text/plain, Size: 2458 bytes --]
# HG changeset patch
# User Fabio Fantoni
# Date 1335169615 -7200
# Node ID b3375cbe809eb8398b75cd2b1590b957134e01f8
# Parent 274e5accd62db09a7f703400c8720f7fdd95551a
Makefile: Some updates to uninstall
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
diff -r 274e5accd62d -r b3375cbe809e Makefile
--- a/Makefile ven apr 20 09:49:06 2012 +0100
+++ b/Makefile lun apr 23 10:26:55 2012 +0200
@@ -220,13 +220,13 @@
uninstall: D=$(DESTDIR)
uninstall:
[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
- rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains $(D)$(CONFIG_DIR)/init.d/xend
+ rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons $(D)$(CONFIG_DIR)/init.d/xen-watchdog
rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xen-backend.rules
rm -f $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
- rm -f $(D)$(CONFIG_DIR)/udev/xend.rules
rm -f $(D)$(SYSCONFIG_DIR)/xendomains
+ rm -f $(D)$(SYSCONFIG_DIR)/xencommons
rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
rm -rf $(D)/boot/*xen*
rm -rf $(D)/lib/modules/*xen*
@@ -236,11 +236,16 @@
rm -rf $(D)$(BINDIR)/pygrub
rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
rm -rf $(D)$(BINDIR)/xsls
- rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+ rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+ rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+ rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+ rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
rm -rf $(D)$(INCLUDEDIR)/xen
+ rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+ rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
- rm -rf $(D)$(LIBDIR)/libxenstore*
+ rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
rm -rf $(D)$(LIBDIR)/xen/
rm -rf $(D)$(LIBEXEC)/xen*
@@ -248,6 +253,7 @@
rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
rm -rf $(D)$(SHAREDIR)/doc/xen
rm -rf $(D)$(SHAREDIR)/xen
+ rm -rf $(D)$(SHAREDIR)/qemu-xen
rm -rf $(D)$(MAN1DIR)/xen*
rm -rf $(D)$(MAN8DIR)/xen*
rm -rf $(D)/boot/tboot*
[-- Attachment #1.2: Firma crittografica S/MIME --]
[-- Type: application/pkcs7-signature, Size: 4497 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Makefile: Some updates to uninstall
2012-04-23 8:42 [PATCH v2] Makefile: Some updates to uninstall Fabio Fantoni
@ 2012-04-24 13:09 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2012-04-24 13:09 UTC (permalink / raw)
To: fantonifabio; +Cc: xen-devel
Fabio Fantoni writes ("[Xen-devel] [PATCH v2] Makefile: Some updates to uninstall"):
> Makefile: Some updates to uninstall
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
I have applied this, TBH without more inspection than needed to
convince myself it won't rm -rf /.
But I think this uninstall target is never tested and I would be
surprised if any of the developers use it. So I think that it's
unlikely to ever be reliable. Perhaps it would be better to remove it
entirely.
Ian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-23 8:42 [PATCH v2] Makefile: Some updates to uninstall Fabio Fantoni
2012-04-24 13:09 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.