From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Dong Aisheng
<dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] pinctrl: fix signed vs unsigned conditional inside pinmux_map_to_setting
Date: Mon, 23 Apr 2012 17:59:46 +0200 [thread overview]
Message-ID: <4F957C72.5030604@openwrt.org> (raw)
In-Reply-To: <4F957ADA.9000203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 23/04/12 17:52, Stephen Warren wrote:
> On 04/23/2012 02:12 AM, John Crispin wrote:
>> pinmux_map_to_settingi() uses setting->data.mux.func to store the return code of
>> pinmux_func_name_to_selector(). However, struct pinctrl_setting_mux defines the
>> func element as unsigned, resulting in all error codes getting lost. The
>> conditional following the assignment will always evaluate to false thus breaking
>> the error path.
> This makes sense.
>
> The exact same issue applies to the assignment to
> setting->data.mux.group just a little below. Can you fix that up too please?
>
missed the group thing, patch coming up ....
prev parent reply other threads:[~2012-04-23 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 8:12 [PATCH] pinctrl: fix signed vs unsigned conditional inside pinmux_map_to_setting John Crispin
[not found] ` <1335168743-3868-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-04-23 15:52 ` Stephen Warren
[not found] ` <4F957ADA.9000203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-23 15:59 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F957C72.5030604@openwrt.org \
--to=blogic-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.