From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 5/9] KVM: MMU: introduce SPTE_WRITE_PROTECT bit
Date: Tue, 24 Apr 2012 11:34:31 +0800 [thread overview]
Message-ID: <4F961F47.6060305@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120424004507.GB14423@amt.cnet>
On 04/24/2012 08:45 AM, Marcelo Tosatti wrote:
>> I think it is not too hard to check. :)
>
> You are minimizing the possible impact these modifications have.
>
> Perhaps you should prepare code under mmu_lock to handle concurrent spte
> R->W updates first, and then later introduce the concurrent updates. In
> a way that its clear for somebody reading the code that parallel updates
> can happen (say read spte once, work on local copy, later re-read spte).
>
Good idea. I will refine it in the next version. Thank you, Marcelo! :)
next prev parent reply other threads:[~2012-04-24 3:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 8:16 [PATCH v3 0/9] KVM: MMU: fast page fault Xiao Guangrong
2012-04-20 8:17 ` [PATCH v3 1/9] KVM: MMU: return bool in __rmap_write_protect Xiao Guangrong
2012-04-20 8:17 ` [PATCH v3 2/9] KVM: MMU: abstract spte write-protect Xiao Guangrong
2012-04-20 21:33 ` Marcelo Tosatti
2012-04-21 1:10 ` Takuya Yoshikawa
2012-04-21 4:34 ` Xiao Guangrong
2012-04-21 3:24 ` Xiao Guangrong
2012-04-21 4:18 ` Marcelo Tosatti
2012-04-21 6:52 ` Xiao Guangrong
2012-04-20 8:18 ` [PATCH v3 3/9] KVM: VMX: export PFEC.P bit on ept Xiao Guangrong
2012-04-20 8:18 ` [PATCH v3 4/9] KVM: MMU: introduce SPTE_ALLOW_WRITE bit Xiao Guangrong
2012-04-20 21:39 ` Marcelo Tosatti
2012-04-21 3:30 ` Xiao Guangrong
2012-04-21 4:22 ` Marcelo Tosatti
2012-04-21 6:55 ` Xiao Guangrong
2012-04-22 15:12 ` Avi Kivity
2012-04-23 7:24 ` Xiao Guangrong
2012-04-20 8:19 ` [PATCH v3 5/9] KVM: MMU: introduce SPTE_WRITE_PROTECT bit Xiao Guangrong
2012-04-20 21:52 ` Marcelo Tosatti
2012-04-21 0:40 ` Marcelo Tosatti
2012-04-21 0:55 ` Marcelo Tosatti
2012-04-21 1:38 ` Takuya Yoshikawa
2012-04-21 4:29 ` Xiao Guangrong
2012-04-21 4:00 ` Xiao Guangrong
2012-04-24 0:45 ` Marcelo Tosatti
2012-04-24 3:34 ` Xiao Guangrong [this message]
2012-04-21 3:47 ` Xiao Guangrong
2012-04-21 4:38 ` Marcelo Tosatti
2012-04-21 7:25 ` Xiao Guangrong
2012-04-24 0:24 ` Marcelo Tosatti
2012-04-20 8:19 ` [PATCH v3 6/9] KVM: MMU: fast path of handling guest page fault Xiao Guangrong
2012-04-20 8:20 ` [PATCH v3 7/9] KVM: MMU: trace fast " Xiao Guangrong
2012-04-20 8:20 ` [PATCH v3 8/9] KVM: MMU: fix kvm_mmu_pagetable_walk tracepoint Xiao Guangrong
2012-04-20 8:21 ` [PATCH v3 9/9] KVM: MMU: document mmu-lock and fast page fault Xiao Guangrong
2012-04-21 0:59 ` [PATCH v3 0/9] KVM: MMU: " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F961F47.6060305@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.