From: peppe.cavallaro@st.com (Giuseppe CAVALLARO)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 6/9] net/stmmac: Remove conditional compilation of clk code
Date: Tue, 24 Apr 2012 10:24:37 +0200 [thread overview]
Message-ID: <4F966345.5080303@st.com> (raw)
In-Reply-To: <4F964B3A.306@st.com>
On 4/24/2012 8:42 AM, Viresh Kumar wrote:
> On 4/24/2012 12:03 PM, Giuseppe CAVALLARO wrote:
>> Oops, sorry but on a build I got:
>>
>> CC init/version.o
>> LD init/built-in.o
>> LD .tmp_vmlinux1
>> drivers/built-in.o: In function `stmmac_release':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1134:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_open':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:974:
>> undefined reference to `clk_enable'
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1079:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_dvr_probe':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1931:
>> undefined reference to `clk_get'
>> drivers/built-in.o: In function `stmmac_clk_csr_set':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:174:
>> undefined reference to `clk_get_rate'
>> drivers/built-in.o: In function `stmmac_suspend':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2030:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_resume':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2054:
>> undefined reference to `clk_enable'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>> Pls, can you verify?
>
> I believe, you haven't applied:
>
> [PATCH V2 1/9] clk: Add non CONFIG_HAVE_CLK routines
>
> which must be applied before testing this.
Yes with it applied the build is ok.
Peppe
>
WARNING: multiple messages have this Message-ID (diff)
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mturquette@linaro.org" <mturquette@linaro.org>,
"sshtylyov@mvista.com" <sshtylyov@mvista.com>,
"jgarzik@redhat.com" <jgarzik@redhat.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
spear-devel <spear-devel@list.st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
ML netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH V2 6/9] net/stmmac: Remove conditional compilation of clk code
Date: Tue, 24 Apr 2012 10:24:37 +0200 [thread overview]
Message-ID: <4F966345.5080303@st.com> (raw)
In-Reply-To: <4F964B3A.306@st.com>
On 4/24/2012 8:42 AM, Viresh Kumar wrote:
> On 4/24/2012 12:03 PM, Giuseppe CAVALLARO wrote:
>> Oops, sorry but on a build I got:
>>
>> CC init/version.o
>> LD init/built-in.o
>> LD .tmp_vmlinux1
>> drivers/built-in.o: In function `stmmac_release':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1134:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_open':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:974:
>> undefined reference to `clk_enable'
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1079:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_dvr_probe':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1931:
>> undefined reference to `clk_get'
>> drivers/built-in.o: In function `stmmac_clk_csr_set':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:174:
>> undefined reference to `clk_get_rate'
>> drivers/built-in.o: In function `stmmac_suspend':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2030:
>> undefined reference to `clk_disable'
>> drivers/built-in.o: In function `stmmac_resume':
>> /stlinux/cavagiu/git/mirror/net-next.git/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2054:
>> undefined reference to `clk_enable'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>> Pls, can you verify?
>
> I believe, you haven't applied:
>
> [PATCH V2 1/9] clk: Add non CONFIG_HAVE_CLK routines
>
> which must be applied before testing this.
Yes with it applied the build is ok.
Peppe
>
next prev parent reply other threads:[~2012-04-24 8:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 5:56 [PATCH V2 0/9] clk: Add non CONFIG_HAVE_CLK routines Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 1/9] " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 2/9] clk: Remove redundant depends on from drivers/Kconfig Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 3/9] ata/pata_arasan: Remove conditional compilation of clk code Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 4/9] ata/sata_mv: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 5/9] net/c_can: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 6/9] net/stmmac: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 6:16 ` Giuseppe CAVALLARO
2012-04-24 6:16 ` Giuseppe CAVALLARO
2012-04-24 6:33 ` Giuseppe CAVALLARO
2012-04-24 6:33 ` Giuseppe CAVALLARO
2012-04-24 6:42 ` Viresh Kumar
2012-04-24 6:42 ` Viresh Kumar
2012-04-24 8:24 ` Giuseppe CAVALLARO [this message]
2012-04-24 8:24 ` Giuseppe CAVALLARO
2012-04-24 5:56 ` [PATCH V2 7/9] gadget/m66592: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 8/9] gadget/r8a66597: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 9/9] usb/host/r8a66597: " Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F966345.5080303@st.com \
--to=peppe.cavallaro@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.