From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: Hiroshi DOYU <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver
Date: Tue, 24 Apr 2012 13:49:22 -0600 [thread overview]
Message-ID: <4F9703C2.50002@wwwdotorg.org> (raw)
In-Reply-To: <20120424121619.GF8444-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
On 04/24/2012 06:16 AM, Felipe Balbi wrote:
> On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote:
>> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
>> High-performance Bus (AHB) architecture.
...
>> +static int __init tegra_ahb_init(void)
>> +{
>> + return platform_driver_register(&tegra_ahb_driver);
>> +}
>> +postcore_initcall(tegra_ahb_init);
>> +
>> +static void __exit tegra_ahb_exit(void)
>> +{
>> + platform_driver_unregister(&tegra_ahb_driver);
>> +}
>> +module_exit(tegra_ahb_exit);
>
> please use module_platform_driver();
That won't work for a postcore_initcall.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: tegra: Add AHB driver
Date: Tue, 24 Apr 2012 13:49:22 -0600 [thread overview]
Message-ID: <4F9703C2.50002@wwwdotorg.org> (raw)
In-Reply-To: <20120424121619.GF8444@arwen.pp.htv.fi>
On 04/24/2012 06:16 AM, Felipe Balbi wrote:
> On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote:
>> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
>> High-performance Bus (AHB) architecture.
...
>> +static int __init tegra_ahb_init(void)
>> +{
>> + return platform_driver_register(&tegra_ahb_driver);
>> +}
>> +postcore_initcall(tegra_ahb_init);
>> +
>> +static void __exit tegra_ahb_exit(void)
>> +{
>> + platform_driver_unregister(&tegra_ahb_driver);
>> +}
>> +module_exit(tegra_ahb_exit);
>
> please use module_platform_driver();
That won't work for a postcore_initcall.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: balbi@ti.com
Cc: Hiroshi DOYU <hdoyu@nvidia.com>,
linux-tegra@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver
Date: Tue, 24 Apr 2012 13:49:22 -0600 [thread overview]
Message-ID: <4F9703C2.50002@wwwdotorg.org> (raw)
In-Reply-To: <20120424121619.GF8444@arwen.pp.htv.fi>
On 04/24/2012 06:16 AM, Felipe Balbi wrote:
> On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote:
>> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
>> High-performance Bus (AHB) architecture.
...
>> +static int __init tegra_ahb_init(void)
>> +{
>> + return platform_driver_register(&tegra_ahb_driver);
>> +}
>> +postcore_initcall(tegra_ahb_init);
>> +
>> +static void __exit tegra_ahb_exit(void)
>> +{
>> + platform_driver_unregister(&tegra_ahb_driver);
>> +}
>> +module_exit(tegra_ahb_exit);
>
> please use module_platform_driver();
That won't work for a postcore_initcall.
next prev parent reply other threads:[~2012-04-24 19:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 12:05 [PATCH v2 1/3] ARM: tegra: Add AHB driver Hiroshi DOYU
2012-04-24 12:05 ` Hiroshi DOYU
2012-04-24 12:05 ` Hiroshi DOYU
2012-04-24 12:05 ` [PATCH v2 2/3] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-04-24 12:05 ` Hiroshi DOYU
2012-04-24 12:32 ` Felipe Balbi
2012-04-24 12:32 ` Felipe Balbi
[not found] ` <20120424123248.GG8444-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-24 12:39 ` Hiroshi Doyu
2012-04-24 12:39 ` Hiroshi Doyu
2012-04-24 12:39 ` Hiroshi Doyu
[not found] ` <20120424.153930.1438573079107186567.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-24 12:41 ` Felipe Balbi
2012-04-24 12:41 ` Felipe Balbi
2012-04-24 12:41 ` Felipe Balbi
[not found] ` <20120424124115.GL8444-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-24 13:03 ` Hiroshi Doyu
2012-04-24 13:03 ` Hiroshi Doyu
2012-04-24 13:03 ` Hiroshi Doyu
2012-04-24 13:25 ` Felipe Balbi
2012-04-24 13:25 ` Felipe Balbi
[not found] ` <1335269116-9578-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-24 19:59 ` Russell King - ARM Linux
2012-04-24 19:59 ` Russell King - ARM Linux
2012-04-24 19:59 ` Russell King - ARM Linux
[not found] ` <1335269116-9578-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-24 12:05 ` [PATCH v2 3/3] iommu/tegra: smmu: Refrain from accessing to AHB registers Hiroshi DOYU
2012-04-24 12:05 ` Hiroshi DOYU
2012-04-24 12:16 ` [PATCH v2 1/3] ARM: tegra: Add AHB driver Felipe Balbi
2012-04-24 12:16 ` Felipe Balbi
2012-04-24 12:16 ` Felipe Balbi
[not found] ` <20120424121619.GF8444-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-24 19:49 ` Stephen Warren [this message]
2012-04-24 19:49 ` Stephen Warren
2012-04-24 19:49 ` Stephen Warren
[not found] ` <4F9703C2.50002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-24 20:31 ` Felipe Balbi
2012-04-24 20:31 ` Felipe Balbi
2012-04-24 20:31 ` Felipe Balbi
2012-04-24 19:56 ` Russell King - ARM Linux
2012-04-24 19:56 ` Russell King - ARM Linux
2012-04-24 19:56 ` Russell King - ARM Linux
[not found] ` <20120424195645.GB3628-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-04-25 5:37 ` Hiroshi Doyu
2012-04-25 5:37 ` Hiroshi Doyu
2012-04-25 5:37 ` Hiroshi Doyu
[not found] ` <20120425083747.466f5c98330af8964d980b8c-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-25 7:46 ` Felipe Balbi
2012-04-25 7:46 ` Felipe Balbi
2012-04-25 7:46 ` Felipe Balbi
2012-04-25 12:15 ` Arnd Bergmann
2012-04-25 12:15 ` Arnd Bergmann
2012-04-25 12:15 ` Arnd Bergmann
[not found] ` <201204251215.22889.arnd-r2nGTMty4D4@public.gmane.org>
2012-04-25 15:59 ` Stephen Warren
2012-04-25 15:59 ` Stephen Warren
2012-04-25 15:59 ` Stephen Warren
[not found] ` <4F981F6C.2050807-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-26 5:49 ` Hiroshi Doyu
2012-04-26 5:49 ` Hiroshi Doyu
2012-04-26 5:49 ` Hiroshi Doyu
2012-04-26 8:14 ` Peter De Schrijver
2012-04-26 8:14 ` Peter De Schrijver
2012-04-26 8:14 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9703C2.50002@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.