From: Kukjin Kim <kgene.kim@samsung.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org
Subject: Re: arch/arm/mach-s3c2410/Kconfig is unsourced
Date: Tue, 24 Apr 2012 17:05:06 -0700 [thread overview]
Message-ID: <4F973FB2.1050004@samsung.com> (raw)
In-Reply-To: <1335090082.1814.27.camel@x61.thuisdomein>
Paul Bolle wrote:
> 0) commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c ("ARM: S3C2410: move
> mach-s3c2410/* into mach-s3c24xx/") orphaned
> arch/arm/mach-s3c2410/Kconfig: currently nothing sources that file in
> Linus' tree.
>
Oops, you're right.
> 1) I haven't looked in depth at this, but this made S3C2410_PLLTABLE
> disappear from the build system (ie, arch/arm/mach-s3c2410/pll.c is dead
> code now). Moreover, this basically turned both "select S3C2410_CPUFREQ
> if CPU_FREQ_S3C24XX", under "config CPU_S3C2410", and "select
> S3C2410_IOTIMING if S3C2410_CPUFREQ", under "config ARCH_BAST", into
> nops (both in arch/arm/mach-s3c24xx/Kconfig).
>
> 2) So to me it seems the move has only been done half: either more
> things needs to be moved or those things can be removed entirely. But
> perhaps arch/arm/mach-s3c2410/Kconfig should just be sourced again.
>
Yes, I think, would be better right now, if we could add just sourcing
mach-s3c2410/Kconfig but as you said, I need to remove entire mach-s3c24
stuff.
Thanks for your pointing out and let me fix it.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: arch/arm/mach-s3c2410/Kconfig is unsourced
Date: Tue, 24 Apr 2012 17:05:06 -0700 [thread overview]
Message-ID: <4F973FB2.1050004@samsung.com> (raw)
In-Reply-To: <1335090082.1814.27.camel@x61.thuisdomein>
Paul Bolle wrote:
> 0) commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c ("ARM: S3C2410: move
> mach-s3c2410/* into mach-s3c24xx/") orphaned
> arch/arm/mach-s3c2410/Kconfig: currently nothing sources that file in
> Linus' tree.
>
Oops, you're right.
> 1) I haven't looked in depth at this, but this made S3C2410_PLLTABLE
> disappear from the build system (ie, arch/arm/mach-s3c2410/pll.c is dead
> code now). Moreover, this basically turned both "select S3C2410_CPUFREQ
> if CPU_FREQ_S3C24XX", under "config CPU_S3C2410", and "select
> S3C2410_IOTIMING if S3C2410_CPUFREQ", under "config ARCH_BAST", into
> nops (both in arch/arm/mach-s3c24xx/Kconfig).
>
> 2) So to me it seems the move has only been done half: either more
> things needs to be moved or those things can be removed entirely. But
> perhaps arch/arm/mach-s3c2410/Kconfig should just be sourced again.
>
Yes, I think, would be better right now, if we could add just sourcing
mach-s3c2410/Kconfig but as you said, I need to remove entire mach-s3c24
stuff.
Thanks for your pointing out and let me fix it.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-04-25 0:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 10:21 arch/arm/mach-s3c2410/Kconfig is unsourced Paul Bolle
2012-04-22 10:21 ` Paul Bolle
2012-04-25 0:05 ` Kukjin Kim [this message]
2012-04-25 0:05 ` Kukjin Kim
2012-06-10 9:57 ` Paul Bolle
2012-06-10 9:57 ` Paul Bolle
2012-06-19 8:50 ` Kukjin Kim
2012-06-19 8:50 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F973FB2.1050004@samsung.com \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.