All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] TRATS: initialize panel_info data structure in board file
@ 2012-04-25 10:40 Donghwa Lee
  0 siblings, 0 replies; only message in thread
From: Donghwa Lee @ 2012-04-25 10:40 UTC (permalink / raw)
  To: u-boot

panel_info data structure is global variable, so, I have initialized it
in board file. If it is initialized in init_panel_info() like existing,
it can't be used in drv_lcd_init() in common/lcd.c because
init_panel_info() is called after drv_lcd_init().

Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 board/samsung/trats/trats.c |   72 ++++++++++++++++++++++--------------------
 drivers/video/exynos_fb.c   |    3 --
 2 files changed, 38 insertions(+), 37 deletions(-)

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index 3085de1..a569c83 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -455,43 +455,47 @@ static int mipi_power(void)
 	return 0;
 }
 
-void init_panel_info(vidinfo_t *vid)
-{
-	vid->vl_freq	= 60;
-	vid->vl_col	= 720;
-	vid->vl_row	= 1280;
-	vid->vl_width	= 720;
-	vid->vl_height	= 1280;
-	vid->vl_clkp	= CONFIG_SYS_HIGH;
-	vid->vl_hsp	= CONFIG_SYS_LOW;
-	vid->vl_vsp	= CONFIG_SYS_LOW;
-	vid->vl_dp	= CONFIG_SYS_LOW;
-
-	vid->vl_bpix	= 5;
-	vid->dual_lcd_enabled = 0;
+vidinfo_t panel_info = {
+	.vl_freq = 60,
+	.vl_col	= 720,
+	.vl_row	= 1280,
+	.vl_width = 720,
+	.vl_height = 1280,
+	.vl_clkp	= CONFIG_SYS_HIGH,
+	.vl_hsp	= CONFIG_SYS_LOW,
+	.vl_vsp	= CONFIG_SYS_LOW,
+	.vl_dp	= CONFIG_SYS_LOW,
+
+	.vl_bpix	= 5,	/* Bits per pixel, 2^5 = 32 */
 
 	/* s6e8ax0 Panel */
-	vid->vl_hspw	= 5;
-	vid->vl_hbpd	= 10;
-	vid->vl_hfpd	= 10;
-
-	vid->vl_vspw	= 2;
-	vid->vl_vbpd	= 1;
-	vid->vl_vfpd	= 13;
-	vid->vl_cmd_allow_len = 0xf;
-
-	vid->win_id = 3;
-	vid->cfg_gpio = NULL;
-	vid->backlight_on = NULL;
-	vid->lcd_power_on = NULL;	/* lcd_power_on in mipi dsi driver */
-	vid->reset_lcd = lcd_reset;
-
-	vid->init_delay = 0;
-	vid->power_on_delay = 0;
-	vid->reset_delay = 0;
-	vid->interface_mode = FIMD_RGB_INTERFACE;
-	vid->mipi_enabled = 1;
+	.vl_hspw	= 5,
+	.vl_hbpd	= 10,
+	.vl_hfpd	= 10,
+
+	.vl_vspw	= 2,
+	.vl_vbpd	= 1,
+	.vl_vfpd	= 13,
+	.vl_cmd_allow_len = 0xf,
+
+	.win_id = 3,
+	.cfg_gpio = NULL,
+	.backlight_on = NULL,
+	.lcd_power_on = NULL,	/* lcd_power_on in mipi dsi driver */
+	.reset_lcd = lcd_reset,
+
+	.init_delay = 0,
+	.power_on_delay = 0,
+	.reset_delay = 0,
+	.interface_mode = FIMD_RGB_INTERFACE,
+	.mipi_enabled = 1,
+	.boot_logo_on = 1,
+	.logo_height = TIZEN_LOGO_HEIGHT,
+	.logo_width = TIZEN_LOGO_WIDTH,
+};
 
+void init_panel_info(vidinfo_t *vid)
+{
 	strcpy(s6e8ax0_platform_data.lcd_panel_name, mipi_lcd_device.name);
 	s6e8ax0_platform_data.lcd_power = lcd_power;
 	s6e8ax0_platform_data.mipi_power = mipi_power;
diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
index a1cf449..96a8ec1 100644
--- a/drivers/video/exynos_fb.c
+++ b/drivers/video/exynos_fb.c
@@ -44,9 +44,6 @@ short console_row;
 
 static unsigned int panel_width, panel_height;
 
-/* LCD Panel data */
-vidinfo_t panel_info;
-
 static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 {
 	unsigned long palette_size;
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-25 10:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 10:40 [U-Boot] [PATCH] TRATS: initialize panel_info data structure in board file Donghwa Lee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.