From: Roland Stigge <stigge@antcom.de>
To: "Poddar, Sourav" <sourav.poddar@ti.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
devicetree-discuss@lists.ozlabs.org,
Benoit Cousson <b-cousson@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Randy Dunlap <rdunlap@xenotime.net>, Felipe Balbi <balbi@ti.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv4 1/2] drivers: input: keypad: Add device tree support
Date: Wed, 25 Apr 2012 14:15:06 +0200 [thread overview]
Message-ID: <4F97EACA.9070603@antcom.de> (raw)
In-Reply-To: <CAKdam57H-JH_vgohMo6Mp3jF46irBJJphj-bHc8SBZUXv564Ug@mail.gmail.com>
Hi!
On 04/25/2012 01:56 PM, Poddar, Sourav wrote:
> Even I was using the bindings as used by samsung-keypad driver. But according
> to the comments and logically too, we should use the common matrix keyboard
> bindings already descibed in
> Documentation/devicetree/bindings/input/matrix-keymap.txt.
Fine with me. Can switch over to
Documentation/devicetree/bindings/input/matrix-keymap.txt
Maybe samsung-keypad should also be converted because it's subnodes
structure duplicates exactly the same thing (row,col,code) in a
different way, and we both were distracted by it, ignoring
matrix-keymap.txt? Or is it already too late (both samsung-keypad and
matrix-keypad both being standards in use) and we should put a
recommendation into one of them to use the other one for new designs?
Thanks,
Roland
WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 1/2] drivers: input: keypad: Add device tree support
Date: Wed, 25 Apr 2012 14:15:06 +0200 [thread overview]
Message-ID: <4F97EACA.9070603@antcom.de> (raw)
In-Reply-To: <CAKdam57H-JH_vgohMo6Mp3jF46irBJJphj-bHc8SBZUXv564Ug@mail.gmail.com>
Hi!
On 04/25/2012 01:56 PM, Poddar, Sourav wrote:
> Even I was using the bindings as used by samsung-keypad driver. But according
> to the comments and logically too, we should use the common matrix keyboard
> bindings already descibed in
> Documentation/devicetree/bindings/input/matrix-keymap.txt.
Fine with me. Can switch over to
Documentation/devicetree/bindings/input/matrix-keymap.txt
Maybe samsung-keypad should also be converted because it's subnodes
structure duplicates exactly the same thing (row,col,code) in a
different way, and we both were distracted by it, ignoring
matrix-keymap.txt? Or is it already too late (both samsung-keypad and
matrix-keypad both being standards in use) and we should put a
recommendation into one of them to use the other one for new designs?
Thanks,
Roland
next prev parent reply other threads:[~2012-04-25 12:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 9:26 [PATCHv4 1/2] drivers: input: keypad: Add device tree support Sourav Poddar
2012-04-25 9:26 ` Sourav Poddar
2012-04-25 9:26 ` Sourav Poddar
2012-04-25 9:26 ` [PATCHv4 2/2] arm/dts: omap4-sdp: Add keypad data Sourav Poddar
2012-04-25 9:26 ` Sourav Poddar
2012-04-25 9:26 ` Sourav Poddar
[not found] ` <1335346004-18108-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2012-04-25 10:52 ` [PATCHv4 1/2] drivers: input: keypad: Add device tree support Russell King - ARM Linux
2012-04-25 10:52 ` Russell King - ARM Linux
2012-04-25 10:52 ` Russell King - ARM Linux
2012-04-25 11:38 ` Roland Stigge
2012-04-25 11:38 ` Roland Stigge
2012-04-25 11:56 ` Poddar, Sourav
2012-04-25 11:56 ` Poddar, Sourav
2012-04-25 11:56 ` Poddar, Sourav
2012-04-25 12:15 ` Roland Stigge [this message]
2012-04-25 12:15 ` Roland Stigge
2012-04-25 13:00 ` Poddar, Sourav
2012-04-25 13:00 ` Poddar, Sourav
2012-04-25 15:48 ` Stephen Warren
2012-04-25 15:48 ` Stephen Warren
2012-04-26 6:33 ` Poddar, Sourav
2012-04-26 6:33 ` Poddar, Sourav
2012-04-26 14:39 ` Stephen Warren
2012-04-26 14:39 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97EACA.9070603@antcom.de \
--to=stigge@antcom.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rdunlap@xenotime.net \
--cc=rob.herring@calxeda.com \
--cc=sourav.poddar@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.