* [RFC] mac80211: fix rate control update on 2040 bss change
@ 2012-04-25 13:01 Rajkumar Manoharan
2012-04-25 14:08 ` Arend van Spriel
0 siblings, 1 reply; 3+ messages in thread
From: Rajkumar Manoharan @ 2012-04-25 13:01 UTC (permalink / raw)
To: johannes; +Cc: linville, linux-wireless, Rajkumar Manoharan
The rate control updatation never be called on 2040 BSS change.
The station should update its rate control on receiving beacon
with different HT mode in the HT operation IE. Not doing so,
leads to sending frames with higher(ht40) rates whereas AP is
running in lower mode (ht20).
Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
---
net/mac80211/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index c8836fa..56128d3 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
disable_40 = true;
if (sta && (!reconfig ||
- (disable_40 != !!(sta->sta.ht_cap.cap &
+ (disable_40 == !!(sta->sta.ht_cap.cap &
IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
if (disable_40)
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] mac80211: fix rate control update on 2040 bss change
2012-04-25 13:01 [RFC] mac80211: fix rate control update on 2040 bss change Rajkumar Manoharan
@ 2012-04-25 14:08 ` Arend van Spriel
2012-04-25 14:44 ` Rajkumar Manoharan
0 siblings, 1 reply; 3+ messages in thread
From: Arend van Spriel @ 2012-04-25 14:08 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: johannes, linville, linux-wireless
On 04/25/2012 03:01 PM, Rajkumar Manoharan wrote:
> The rate control updatation never be called on 2040 BSS change.
'updatation' == typo?
> The station should update its rate control on receiving beacon
> with different HT mode in the HT operation IE. Not doing so,
> leads to sending frames with higher(ht40) rates whereas AP is
> running in lower mode (ht20).
>
> Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
> ---
> net/mac80211/mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index c8836fa..56128d3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
> disable_40 = true;
>
> if (sta&& (!reconfig ||
> - (disable_40 != !!(sta->sta.ht_cap.cap&
> + (disable_40 == !!(sta->sta.ht_cap.cap&
> IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
>
> if (disable_40)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] mac80211: fix rate control update on 2040 bss change
2012-04-25 14:08 ` Arend van Spriel
@ 2012-04-25 14:44 ` Rajkumar Manoharan
0 siblings, 0 replies; 3+ messages in thread
From: Rajkumar Manoharan @ 2012-04-25 14:44 UTC (permalink / raw)
To: Arend van Spriel; +Cc: johannes, linville, linux-wireless
On Wed, Apr 25, 2012 at 04:08:17PM +0200, Arend van Spriel wrote:
> On 04/25/2012 03:01 PM, Rajkumar Manoharan wrote:
> >The rate control updatation never be called on 2040 BSS change.
>
> 'updatation' == typo?
>
yep. thanks
> >The station should update its rate control on receiving beacon
> >with different HT mode in the HT operation IE. Not doing so,
> >leads to sending frames with higher(ht40) rates whereas AP is
> >running in lower mode (ht20).
> >
> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
> >---
> > net/mac80211/mlme.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> >index c8836fa..56128d3 100644
> >--- a/net/mac80211/mlme.c
> >+++ b/net/mac80211/mlme.c
> >@@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
> > disable_40 = true;
> >
> > if (sta&& (!reconfig ||
> >- (disable_40 != !!(sta->sta.ht_cap.cap&
> >+ (disable_40 == !!(sta->sta.ht_cap.cap&
> > IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
> >
Jouni,
To make it more readable, will change as follows
+ (disable_40 != !(sta->sta.ht_cap.cap&
-Rajkumar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-25 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-25 13:01 [RFC] mac80211: fix rate control update on 2040 bss change Rajkumar Manoharan
2012-04-25 14:08 ` Arend van Spriel
2012-04-25 14:44 ` Rajkumar Manoharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.