Re: [PATCH 06/26] drm/radeon: fix a critical bug in the SA code

["Christian König" <deathsimple@vodafone.de>]

On 25.04.2012 16:34, Jerome Glisse wrote:
> On Wed, Apr 25, 2012 at 9:40 AM, Alex Deucher<alexdeucher@gmail.com>  wrote:
>> On Wed, Apr 25, 2012 at 9:19 AM, Michel Dänzer<michel@daenzer.net>  wrote:
>>> On Mit, 2012-04-25 at 14:46 +0200, Christian König wrote:
>>>> Aligning offset can make it bigger than tmp->offset
>>>> leading to an overrun bug in the following subtraction.
>>>>
>>>> Signed-off-by: Christian König<deathsimple@vodafone.de>
>>> Please add
>>>
>>> Cc: stable@vger.kernel.org
>>>
>>> to the commit log (but don't send the patch to that address during
>>> review). That way, once Linus merges the fix, it'll be picked up for the
>>> 3.3.y stable tree.
>>>
>>> With that addition,
>>>
>>> Reviewed-by: Michel Dänzer<michel.daenzer@amd.com>
>> Reviewed-by: Alex Deucher<alexander.deucher@amd.com>
>>
>> This should probably go in now via drm-fixes (with stable cced).  Might fix:
>> https://bugs.freedesktop.org/show_bug.cgi?id=45018
>>
>> Alex
> I don't think this patch fix anything, as up until now they all used
> same alignment.
Correct, as I allready mentioned in the other mail: The VM code and the 
IB code do use different alignments, but they also use different 
instances of SA manager. So that problem won't hurt us in the current 
mainline.

Christian.