From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Teoh <htmldeveloper@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org
Subject: Re: [BUG]memblock: fix overflow of array index
Date: Wed, 25 Apr 2012 15:29:31 -0700 [thread overview]
Message-ID: <4F987ACB.8050604@linux.intel.com> (raw)
In-Reply-To: <20120425222819.GF8989@google.com>
On 04/25/2012 03:28 PM, Tejun Heo wrote:
>
> All indexes in memblock are integers. Changing that particular one to
> unsigned int doesn't fix anything. I think it just makes things more
> confusing. If there ever are cases w/ more then 2G memblocks, we're
> going for 64bit not unsigned.
>
I would expect there to be plenty of memblocks larger than 2G?
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Teoh <htmldeveloper@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org
Subject: Re: [BUG]memblock: fix overflow of array index
Date: Wed, 25 Apr 2012 15:29:31 -0700 [thread overview]
Message-ID: <4F987ACB.8050604@linux.intel.com> (raw)
In-Reply-To: <20120425222819.GF8989@google.com>
On 04/25/2012 03:28 PM, Tejun Heo wrote:
>
> All indexes in memblock are integers. Changing that particular one to
> unsigned int doesn't fix anything. I think it just makes things more
> confusing. If there ever are cases w/ more then 2G memblocks, we're
> going for 64bit not unsigned.
>
I would expect there to be plenty of memblocks larger than 2G?
-hpa
next prev parent reply other threads:[~2012-04-25 22:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 8:30 [BUG]memblock: fix overflow of array index Peter Teoh
2012-04-25 8:30 ` Peter Teoh
2012-04-25 22:28 ` Tejun Heo
2012-04-25 22:28 ` Tejun Heo
2012-04-25 22:29 ` H. Peter Anvin [this message]
2012-04-25 22:29 ` H. Peter Anvin
2012-04-25 22:31 ` David Miller
2012-04-25 22:31 ` David Miller
2012-04-25 22:42 ` H. Peter Anvin
2012-04-25 22:42 ` H. Peter Anvin
2012-04-26 0:50 ` Peter Teoh
2012-04-26 0:50 ` Peter Teoh
2012-04-26 0:54 ` Yinghai Lu
2012-04-26 0:54 ` Yinghai Lu
2012-04-26 15:01 ` Tejun Heo
2012-04-26 15:01 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F987ACB.8050604@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.