From: "Arend van Spriel" <arend@broadcom.com>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless: properly use pr_fmt()
Date: Thu, 26 Apr 2012 14:44:57 +0200 [thread overview]
Message-ID: <4F994349.1040607@broadcom.com> (raw)
In-Reply-To: <1335234998-31547-1-git-send-email-mcgrof@frijolero.org>
On 04/24/2012 04:36 AM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez"<mcgrof@frijolero.org>
>
> pr_fmt() is either defined or we redefine it. Typically
> drivers define it prior to including printk.h but this
> is done under the assumption that no other subsystem
> it uses has already defined pr_fmt(). In such cases
> pr_fmt() should be undefined and redefined.
>
> Doing this properly shaves down compilation time quite
> considerably.
>
> Signed-off-by: Luis R. Rodriguez<mcgrof@frijolero.org>
Hi Luis,
I actually recall some patches removing inclusion of printk.h sometime
ago. Not sure what the motivation was, but I will start digging the git
revision logs.
Gr. AvS
next prev parent reply other threads:[~2012-04-26 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 2:36 [PATCH 1/2] wireless: properly use pr_fmt() Luis R. Rodriguez
2012-04-24 2:36 ` [PATCH 2/2] ath6kl: " Luis R. Rodriguez
2012-04-26 11:35 ` Kalle Valo
2012-04-24 5:50 ` [PATCH 1/2] wireless: " Johannes Berg
2012-04-24 6:41 ` Luis R. Rodriguez
2012-04-25 6:49 ` Kalle Valo
2012-04-26 12:44 ` Arend van Spriel [this message]
2012-04-26 12:54 ` Arend van Spriel
2012-04-26 13:03 ` Hauke Mehrtens
2012-04-26 13:15 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F994349.1040607@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.