From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless: properly use pr_fmt()
Date: Thu, 26 Apr 2012 15:03:13 +0200 [thread overview]
Message-ID: <4F994791.8020801@hauke-m.de> (raw)
In-Reply-To: <1335234998-31547-1-git-send-email-mcgrof@frijolero.org>
On 04/24/2012 04:36 AM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@frijolero.org>
>
> pr_fmt() is either defined or we redefine it. Typically
> drivers define it prior to including printk.h but this
> is done under the assumption that no other subsystem
> it uses has already defined pr_fmt(). In such cases
> pr_fmt() should be undefined and redefined.
>
> Doing this properly shaves down compilation time quite
> considerably.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@frijolero.org>
> ---
>
> I left out only ath6kl as ath6kl folks get groggy it seems
> if you do not go through their tree. Bleh.
>
> drivers/net/wireless/ath/ath5k/ani.c | 3 +++
> drivers/net/wireless/ath/ath5k/attach.c | 2 ++
> drivers/net/wireless/ath/ath5k/base.c | 2 ++
> drivers/net/wireless/ath/ath5k/desc.c | 3 +++
> drivers/net/wireless/ath/ath5k/dma.c | 3 +++
> drivers/net/wireless/ath/ath5k/eeprom.c | 2 ++
> drivers/net/wireless/ath/ath5k/initvals.c | 3 +++
> drivers/net/wireless/ath/ath5k/led.c | 2 ++
> drivers/net/wireless/ath/ath5k/mac80211-ops.c | 3 +++
> drivers/net/wireless/ath/ath5k/pci.c | 2 ++
> drivers/net/wireless/ath/ath5k/phy.c | 2 ++
> drivers/net/wireless/ath/ath5k/qcu.c | 3 +++
> drivers/net/wireless/ath/ath5k/reset.c | 2 ++
> drivers/net/wireless/ath/ath5k/sysfs.c | 2 ++
> drivers/net/wireless/ath/ath9k/htc_drv_init.c | 3 +++
> drivers/net/wireless/ath/ath9k/htc_hst.c | 3 +++
> drivers/net/wireless/ath/ath9k/init.c | 2 ++
> drivers/net/wireless/ath/ath9k/pci.c | 2 ++
> drivers/net/wireless/ath/main.c | 2 ++
> drivers/net/wireless/ath/regd.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 1 +
> drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c | 2 ++
> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 ++
> drivers/net/wireless/brcm80211/brcmsmac/aiutils.c | 2 ++
> drivers/net/wireless/brcm80211/brcmsmac/dma.c | 3 ++-
> drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 2 ++
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 ++
> drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c | 2 ++
> drivers/net/wireless/brcm80211/brcmutil/utils.c | 2 ++
> drivers/net/wireless/iwlegacy/3945-mac.c | 2 ++
> drivers/net/wireless/iwlegacy/4965-mac.c | 2 ++
> drivers/net/wireless/iwlwifi/iwl-agn.c | 2 ++
> drivers/net/wireless/iwlwifi/iwl-pci.c | 2 ++
> drivers/net/wireless/libertas/cfg.c | 2 ++
> drivers/net/wireless/libertas/if_cs.c | 2 ++
> drivers/net/wireless/libertas/if_sdio.c | 2 ++
> drivers/net/wireless/libertas/if_spi.c | 2 ++
> drivers/net/wireless/libertas/if_usb.c | 2 ++
> drivers/net/wireless/libertas/main.c | 2 ++
> drivers/net/wireless/libertas/mesh.c | 2 ++
> drivers/net/wireless/libertas/rx.c | 2 ++
> drivers/net/wireless/libertas_tf/cmd.c | 2 ++
> drivers/net/wireless/libertas_tf/if_usb.c | 2 ++
> drivers/net/wireless/libertas_tf/main.c | 2 ++
> drivers/net/wireless/rtlwifi/wifi.h | 2 ++
> net/wireless/core.c | 2 ++
> net/wireless/lib80211.c | 2 ++
> net/wireless/lib80211_crypt_tkip.c | 2 ++
> net/wireless/reg.c | 2 ++
> 54 files changed, 115 insertions(+), 1 deletion(-)
>
Hi Luis,
the problem here is that compat-wireless globally includes lots of
header files from the kernel and that also includes printk.h. I made a
patch some time ago to restructure compat so that we do not have to
include all these headers files globally. I will work on that again and
will try to send a RFC patches sometime today. This also fixed the
pr_fmt() problem without the need of any patches in
compat-wireless/patches and made it possible to remove some other
patches as well.
My plan was to place the compat header code which is now in
compat/include/linux/compat-*.h into the headers where it is in the
mainline kernel and include the original file with inlcude_next.
Hauke
next prev parent reply other threads:[~2012-04-26 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 2:36 [PATCH 1/2] wireless: properly use pr_fmt() Luis R. Rodriguez
2012-04-24 2:36 ` [PATCH 2/2] ath6kl: " Luis R. Rodriguez
2012-04-26 11:35 ` Kalle Valo
2012-04-24 5:50 ` [PATCH 1/2] wireless: " Johannes Berg
2012-04-24 6:41 ` Luis R. Rodriguez
2012-04-25 6:49 ` Kalle Valo
2012-04-26 12:44 ` Arend van Spriel
2012-04-26 12:54 ` Arend van Spriel
2012-04-26 13:03 ` Hauke Mehrtens [this message]
2012-04-26 13:15 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F994791.8020801@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.