From: Stephen Warren <swarren@wwwdotorg.org>
To: Hiroshi DOYU <hdoyu@nvidia.com>
Cc: swarren@nvidia.com, Joerg Roedel <joerg.roedel@amd.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB registers
Date: Thu, 26 Apr 2012 13:58:32 -0600 [thread overview]
Message-ID: <4F99A8E8.7090909@wwwdotorg.org> (raw)
In-Reply-To: <1335352072-4001-3-git-send-email-hdoyu@nvidia.com>
On 04/25/2012 05:07 AM, Hiroshi DOYU wrote:
> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
> ready, instead of directly aceessing AHB registers.
> @@ -397,11 +384,7 @@ static void smmu_setup_regs(struct smmu_device *smmu)
...
> + tegra_ahb_enable_smmu();
You need to check for an error there, and make smmu_setup_regs()
propagate any error back to its callers and check it there too.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB registers
Date: Thu, 26 Apr 2012 13:58:32 -0600 [thread overview]
Message-ID: <4F99A8E8.7090909@wwwdotorg.org> (raw)
In-Reply-To: <1335352072-4001-3-git-send-email-hdoyu@nvidia.com>
On 04/25/2012 05:07 AM, Hiroshi DOYU wrote:
> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
> ready, instead of directly aceessing AHB registers.
> @@ -397,11 +384,7 @@ static void smmu_setup_regs(struct smmu_device *smmu)
...
> + tegra_ahb_enable_smmu();
You need to check for an error there, and make smmu_setup_regs()
propagate any error back to its callers and check it there too.
next prev parent reply other threads:[~2012-04-26 19:58 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 11:07 [PATCHv3 1/4] ARM: tegra: Add AHB driver Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
2012-04-25 11:07 ` [PATCHv3 2/4] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
[not found] ` <1335352072-4001-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-25 11:29 ` Felipe Balbi
2012-04-25 11:29 ` Felipe Balbi
2012-04-25 11:29 ` Felipe Balbi
[not found] ` <20120425112950.GC3564-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-25 15:51 ` Stephen Warren
2012-04-25 15:51 ` Stephen Warren
2012-04-25 15:51 ` Stephen Warren
2012-04-26 5:37 ` Hiroshi Doyu
2012-04-26 5:37 ` Hiroshi Doyu
2012-04-26 5:37 ` Hiroshi Doyu
2012-04-26 19:55 ` Stephen Warren
2012-04-26 19:55 ` Stephen Warren
2012-04-26 19:55 ` Stephen Warren
2012-04-26 20:26 ` Felipe Balbi
2012-04-26 20:26 ` Felipe Balbi
[not found] ` <20120426202610.GA30690-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-26 20:32 ` Stephen Warren
2012-04-26 20:32 ` Stephen Warren
2012-04-26 20:32 ` Stephen Warren
2012-04-26 20:38 ` Felipe Balbi
2012-04-26 20:38 ` Felipe Balbi
2012-04-27 6:48 ` Hiroshi Doyu
2012-04-27 6:48 ` Hiroshi Doyu
[not found] ` <20120427.094826.1181797260264746303.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-27 6:55 ` Hiroshi Doyu
2012-04-27 6:55 ` Hiroshi Doyu
2012-04-27 6:55 ` Hiroshi Doyu
2012-04-27 15:49 ` Stephen Warren
2012-04-27 15:49 ` Stephen Warren
[not found] ` <1335352072-4001-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-25 11:07 ` [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB registers Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
2012-04-26 19:58 ` Stephen Warren [this message]
2012-04-26 19:58 ` Stephen Warren
2012-04-25 11:07 ` [PATCHv3 4/4] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
2012-04-25 11:07 ` Hiroshi DOYU
[not found] ` <1335352072-4001-4-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-26 20:01 ` Stephen Warren
2012-04-26 20:01 ` Stephen Warren
2012-04-26 20:01 ` Stephen Warren
2012-04-26 19:51 ` [PATCHv3 1/4] ARM: tegra: Add AHB driver Stephen Warren
2012-04-26 19:51 ` Stephen Warren
2012-04-26 19:51 ` Stephen Warren
[not found] ` <4F99A740.3080407-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-26 21:59 ` Russell King - ARM Linux
2012-04-26 21:59 ` Russell King - ARM Linux
2012-04-26 21:59 ` Russell King - ARM Linux
[not found] ` <20120426215903.GH24211-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-04-27 5:40 ` Hiroshi Doyu
2012-04-27 5:40 ` Hiroshi Doyu
2012-04-27 5:40 ` Hiroshi Doyu
[not found] ` <20120427084015.cb7c8e00c7d9a4cd01faa5ae-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-30 14:47 ` Arnd Bergmann
2012-04-30 14:47 ` Arnd Bergmann
2012-04-30 14:47 ` Arnd Bergmann
2012-04-25 11:25 ` Felipe Balbi
2012-04-25 11:25 ` Felipe Balbi
2012-04-25 11:25 ` Felipe Balbi
[not found] ` <20120425112519.GB3564-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-25 13:01 ` Hiroshi Doyu
2012-04-25 13:01 ` Hiroshi Doyu
2012-04-25 13:01 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F99A8E8.7090909@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=hdoyu@nvidia.com \
--cc=joerg.roedel@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.