Re: usb midi keyboard broken [3.3.3 regression]

Re: usb midi keyboard broken [3.3.3 regression]

[Jiri Slaby]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/27/2012 09:37 AM, Steffen Müller wrote:
>> [  224.418062] usb 1-1.3: USB disconnect, device number 6 [
>> 227.662396] usb 1-1.3: new full-speed USB device number 7 using
>> ehci_hcd [  227.749541] usb 1-1.3: New USB device found,
>> idVendor=0763, idProduct=0192 [  227.749550] usb 1-1.3: New USB
>> device strings: Mfr=1, Product=2, SerialNumber=0 [  227.749556]
>> usb 1-1.3: Product: USB Keystation 88es [  227.749560] usb 1-1.3:
>> Manufacturer: M-Audio [  229.750236] ALSA midi.c:214 urb status
>> -32 [  229.750700] ALSA midi.c:214 urb status -32 [  229.750911]
>> ALSA midi.c:214 urb status -32 [  229.751175] ALSA midi.c:214 urb
>> status -32 [  229.751413] ALSA midi.c:214 urb status -32 [
>> 229.751659] ALSA midi.c:214 urb status -32 [  229.751910] ALSA
>> midi.c:214 urb status -32 [  229.752210] ALSA midi.c:214 urb
>> status -32 [  229.752459] ALSA midi.c:214 urb status -32 [
>> 229.752662] ALSA midi.c:214 urb status -32

Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?

3.3.2 is reported to work.

thanks,
- -- 
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPmk7tAAoJEL0lsQQGtHBJRjMQAISHi8yIkLvpJDZjKM/uY5px
II9wXE8D4rhgjXaeOADFS92lPyaLES1IJYRudh5QRRsOfguU7y0iZSbqukpaaJse
EOcQSRvtKjzQOn0qmvAuYDORYLWELJG+TDeMas+4ecBFygEmzIAkmgULJsw1dkQR
L7H7B+pVL9lKdBQg0annMxxqPkxbrRL8kYu4ZkNOLhKdk6SNcMw4KBq7xVQc1Jfa
GwDdHdpE6/2D9UE4fiEU4q7FTCeF+on1GYnpw8+P6CJT2ovNcp0GF1TeW4q5yAMx
YgkOjyUXzYnbz5j9jHVkZgOgCXKudj/AdexuehMnC+YXqPFG40cc0KHWHhBh5LbG
7TJ6zJ0bby7yazk3mV1P099eR6YinB7zsHWHhW6COwh4t6ZeWOAQVUbL2mAFoOZy
Dq9S8wVnQKj+/M5ewWjTnX6yVbySJ/wDfVRx+HRiyEvARqFyHC9EdAsQG+aHHlU1
RDu+56CprOnkvsNXaZUabRUZVfOyVfpYeWBXEkcd8nSDmqUnnOUpgy4035YjTsAf
MU8ph+r3PqepDyjW1uaE+CTApGjD38Dxrt070yxtqOhBntBZp/WXYUkDq5BQEcnr
o35xfluDIiUQzhYzbO92Qr+MA03moVcQXG72s+2cnAWdTw5+zo3VCHfEgZtdpmFN
2mRV1ljPbjt9314rGTXv
=vE/l
-----END PGP SIGNATURE-----

Re: usb midi keyboard broken [3.3.3 regression]

[Alan Stern]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=UTF-8, Size: 1325 bytes --]

On Fri, 27 Apr 2012, Jiri Slaby wrote:

> On 04/27/2012 09:37 AM, Steffen Müller wrote:
> >> [  224.418062] usb 1-1.3: USB disconnect, device number 6 [
> >> 227.662396] usb 1-1.3: new full-speed USB device number 7 using
> >> ehci_hcd [  227.749541] usb 1-1.3: New USB device found,
> >> idVendor=0763, idProduct=0192 [  227.749550] usb 1-1.3: New USB
> >> device strings: Mfr=1, Product=2, SerialNumber=0 [  227.749556]
> >> usb 1-1.3: Product: USB Keystation 88es [  227.749560] usb 1-1.3:
> >> Manufacturer: M-Audio [  229.750236] ALSA midi.c:214 urb status
> >> -32 [  229.750700] ALSA midi.c:214 urb status -32 [  229.750911]
> >> ALSA midi.c:214 urb status -32 [  229.751175] ALSA midi.c:214 urb
> >> status -32 [  229.751413] ALSA midi.c:214 urb status -32 [
> >> 229.751659] ALSA midi.c:214 urb status -32 [  229.751910] ALSA
> >> midi.c:214 urb status -32 [  229.752210] ALSA midi.c:214 urb
> >> status -32 [  229.752459] ALSA midi.c:214 urb status -32 [
> >> 229.752662] ALSA midi.c:214 urb status -32
> 
> Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?
> 
> 3.3.2 is reported to work.

No ideas.  It would be good to see a usbmon trace, with as many other 
USB devices unplugged as possible.  Even better would be to see also a 
second usbmon trace from a working kernel.

Alan Stern

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Steffen Müller]

Oh man! After look and try many usr relevant settings I found the malfactor: 
tlp usb autosuspend settings.

I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend usb 
devices by default. Now I have blacklisted my midi keyboard an all is good. I 
can reproduce the problem this way. Seems so that the midi keyboard doesn't 
wake up if it once sleeping.

For all with similar problems: 
edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or 
disable usb autosuspend entirely with USB_AUTOSUSPEND=0

thanks and sorry for the bother.
steffen


Am Freitag, 27. April 2012, 11:26:12 schrieb Alan Stern:
> On Fri, 27 Apr 2012, Jiri Slaby wrote:
> > On 04/27/2012 09:37 AM, Steffen M�ller wrote:
> > >> [  224.418062] usb 1-1.3: USB disconnect, device number 6 [
> > >> 227.662396] usb 1-1.3: new full-speed USB device number 7 using
> > >> ehci_hcd [  227.749541] usb 1-1.3: New USB device found,
> > >> idVendor=0763, idProduct=0192 [  227.749550] usb 1-1.3: New USB
> > >> device strings: Mfr=1, Product=2, SerialNumber=0 [  227.749556]
> > >> usb 1-1.3: Product: USB Keystation 88es [  227.749560] usb 1-1.3:
> > >> Manufacturer: M-Audio [  229.750236] ALSA midi.c:214 urb status
> > >> -32 [  229.750700] ALSA midi.c:214 urb status -32 [  229.750911]
> > >> ALSA midi.c:214 urb status -32 [  229.751175] ALSA midi.c:214 urb
> > >> status -32 [  229.751413] ALSA midi.c:214 urb status -32 [
> > >> 229.751659] ALSA midi.c:214 urb status -32 [  229.751910] ALSA
> > >> midi.c:214 urb status -32 [  229.752210] ALSA midi.c:214 urb
> > >> status -32 [  229.752459] ALSA midi.c:214 urb status -32 [
> > >> 229.752662] ALSA midi.c:214 urb status -32
> > 
> > Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?
> > 
> > 3.3.2 is reported to work.
> 
> No ideas.  It would be good to see a usbmon trace, with as many other
> USB devices unplugged as possible.  Even better would be to see also a
> second usbmon trace from a working kernel.
> 
> Alan Stern

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Oliver Neukum]

Am Samstag, 28. April 2012, 13:45:56 schrieb Steffen Müller:
> Oh man! After look and try many usr relevant settings I found the malfactor: 
> tlp usb autosuspend settings.
> 
> I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend usb 
> devices by default. Now I have blacklisted my midi keyboard an all is good. I 
> can reproduce the problem this way. Seems so that the midi keyboard doesn't 
> wake up if it once sleeping.
> 
> For all with similar problems: 
> edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or 
> disable usb autosuspend entirely with USB_AUTOSUSPEND=0
> 
> thanks and sorry for the bother.

No problem, but we ought to test whether we can make it work with a kernel
quirk. Can you please test whether it works with USB_QUIRK_RESET_RESUME
in drivers/usb/core/quirks.c ?

	Regards
		Oliver

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Steffen Müller]

Am Samstag, 28. April 2012, 17:30:04 schrieb Oliver Neukum:
> Am Samstag, 28. April 2012, 13:45:56 schrieb Steffen Müller:
> > Oh man! After look and try many usr relevant settings I found the
> > malfactor: tlp usb autosuspend settings.
> > 
> > I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend
> > usb devices by default. Now I have blacklisted my midi keyboard an all is
> > good. I can reproduce the problem this way. Seems so that the midi
> > keyboard doesn't wake up if it once sleeping.
> > 
> > For all with similar problems:
> > edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or
> > disable usb autosuspend entirely with USB_AUTOSUSPEND=0
> > 
> > thanks and sorry for the bother.
> 
> No problem, but we ought to test whether we can make it work with a kernel
> quirk. Can you please test whether it works with USB_QUIRK_RESET_RESUME
> in drivers/usb/core/quirks.c ?
> 

yes, it works now without blacklisting for autosuspend after build patched 
kernel with this in drivers/usb/core/quirks.c

rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c 
--- quirks-org.c        2012-04-28 23:19:45.440959001 +0200
+++ quirks.c    2012-04-28 20:38:50.000000000 +0200
@@ -123,6 +123,9 @@
        /* Guillemot Webcam Hercules Dualpix Exchange*/
        { USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
 
+       /* Midiman M-Audio Keystation 88es */
+       { USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
+
        /* M-Systems Flash Disk Pioneers */
        { USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 
rf@ThinkpadSM:~/tmp> 

regards
steffen
 

> 	Regards
> 		Oliver

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Oliver Neukum]

Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:
> yes, it works now without blacklisting for autosuspend after build patched 
> kernel with this in drivers/usb/core/quirks.c
> 
> rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c 
> --- quirks-org.c        2012-04-28 23:19:45.440959001 +0200
> +++ quirks.c    2012-04-28 20:38:50.000000000 +0200
> @@ -123,6 +123,9 @@
>         /* Guillemot Webcam Hercules Dualpix Exchange*/
>         { USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> +       /* Midiman M-Audio Keystation 88es */
> +       { USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
> +
>         /* M-Systems Flash Disk Pioneers */
>         { USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> rf@ThinkpadSM:~/tmp> 

Could you please send a formal patch with "Signed-off-by" and stuff
upstream?

	Regards
		Oliver

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Steffen Müller]

Am Montag, 30. April 2012, 10:48:21 schrieb Oliver Neukum:
> Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:
> > yes, it works now without blacklisting for autosuspend after build patched
> > kernel with this in drivers/usb/core/quirks.c
> > 
> > rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c
> > --- quirks-org.c        2012-04-28 23:19:45.440959001 +0200
> > +++ quirks.c    2012-04-28 20:38:50.000000000 +0200
> > @@ -123,6 +123,9 @@
> > 
> >         /* Guillemot Webcam Hercules Dualpix Exchange*/
> >         { USB_DEVICE(0x06f8, 0x3005), .driver_info =
> >         USB_QUIRK_RESET_RESUME },
> > 
> > +       /* Midiman M-Audio Keystation 88es */
> > +       { USB_DEVICE(0x0763, 0x0192), .driver_info =
> > USB_QUIRK_RESET_RESUME }, +
> > 
> >         /* M-Systems Flash Disk Pioneers */
> >         { USB_DEVICE(0x08ec, 0x1000), .driver_info =
> >         USB_QUIRK_RESET_RESUME },
> > 
> > rf@ThinkpadSM:~/tmp>
> 
> Could you please send a formal patch with "Signed-off-by" and stuff
> upstream?
> 

hmm... I would but I've never done this before. No idea how to do this.

> 	Regards
> 		Oliver

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Mon, Apr 30, 2012 at 11:00:05AM +0200, Steffen Müller wrote:
> Am Montag, 30. April 2012, 10:48:21 schrieb Oliver Neukum:
> > Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:
> > > yes, it works now without blacklisting for autosuspend after build patched
> > > kernel with this in drivers/usb/core/quirks.c
> > > 
> > > rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c
> > > --- quirks-org.c        2012-04-28 23:19:45.440959001 +0200
> > > +++ quirks.c    2012-04-28 20:38:50.000000000 +0200
> > > @@ -123,6 +123,9 @@
> > > 
> > >         /* Guillemot Webcam Hercules Dualpix Exchange*/
> > >         { USB_DEVICE(0x06f8, 0x3005), .driver_info =
> > >         USB_QUIRK_RESET_RESUME },
> > > 
> > > +       /* Midiman M-Audio Keystation 88es */
> > > +       { USB_DEVICE(0x0763, 0x0192), .driver_info =
> > > USB_QUIRK_RESET_RESUME }, +
> > > 
> > >         /* M-Systems Flash Disk Pioneers */
> > >         { USB_DEVICE(0x08ec, 0x1000), .driver_info =
> > >         USB_QUIRK_RESET_RESUME },
> > > 
> > > rf@ThinkpadSM:~/tmp>
> > 
> > Could you please send a formal patch with "Signed-off-by" and stuff
> > upstream?
> > 
> 
> hmm... I would but I've never done this before. No idea how to do this.

Take a look at Documentation/SubmittingPatches, it has all the
information you need ;-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 88es

[Steffen Müller]

Tested-by:     Steffen Müller <steffen.mueller@radio-frei.de>
Signed-off-by: Steffen Müller <steffen.mueller@radio-frei.de>
Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
---
 drivers/usb/core/quirks.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 4c65eb6..32d3adc 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -123,6 +123,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Guillemot Webcam Hercules Dualpix Exchange*/
 	{ USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Midiman M-Audio Keystation 88es */
+	{ USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
+
 	/* M-Systems Flash Disk Pioneers */
 	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 
--