From: Michael Tokarev <mjt@tls.msk.ru>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Thomas Meyer <thomas@m3y3r.de>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, autofs@vger.kernel.org,
raven@themaw.net, stable@kernel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.
Date: Sun, 29 Apr 2012 11:45:21 +0400 [thread overview]
Message-ID: <4F9CF191.5020607@msgid.tls.msk.ru> (raw)
In-Reply-To: <CA+55aFyS9VYT50JAXeGrLrtFVWSGr+DMTA1hhrcPYzmjrSV5+A@mail.gmail.com>
[Hit "reply" instead of "Reply to all".. I'm sorry for a repost]
On 29.04.2012 11:19, Linus Torvalds wrote:
[]
>> /proc/1/fdinfo/16 -- the autofs pipe fd# -- shows flags=02004000
>> which is O_CLOEXEC|O_NONBLOCK, but this is the other end of the
>> pipe.. shouldn't the READ side of the pipe have O_DIRECT flag now?
>
> Gaah, it should, but it won't.
>
> I bet my original patch worked fine, because the pipe has only one
> inode and pipe structure. But it has *two* 'struct file's associated
> with it, and autofs only ever sees the writing side, and never gets to
> mark the reading side O_DIRECT. So yeah, the reading side won't do the
> proper packetized read.
Can't we go - in kernel - from one struct file to pipe structure to
another file structure and set O_DIRECT there? Autofs kernel code
checks if the file descriptor is a pipe, so it should be possible...
Thanks,
/mjt
next prev parent reply other threads:[~2012-04-29 7:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 13:34 [PATCH v2] Introduce a version6 of autofs interface, to fix design error Michael Tokarev
2012-04-26 13:44 ` Michael Tokarev
2012-04-27 0:37 ` Linus Torvalds
2012-04-27 9:45 ` Michael Tokarev
2012-04-27 15:47 ` Mark Lord
2012-04-27 20:37 ` H. Peter Anvin
2012-04-28 22:20 ` Mark Lord
2012-04-27 16:22 ` David Miller
2012-04-27 17:10 ` Michael Tokarev
2012-04-27 17:28 ` David Miller
2012-04-27 18:19 ` Linus Torvalds
2012-04-27 18:34 ` David Miller
2012-04-27 18:42 ` Linus Torvalds
2012-04-27 18:55 ` Linus Torvalds
2012-04-27 19:14 ` David Miller
2012-04-27 19:16 ` David Miller
2012-04-27 19:19 ` Linus Torvalds
2012-04-27 19:24 ` David Miller
2012-04-27 19:56 ` Linus Torvalds
2012-04-27 20:13 ` Stef Bon
2012-04-27 20:29 ` David Miller
2012-04-27 22:40 ` Linus Torvalds
2012-04-27 20:43 ` H. Peter Anvin
2012-04-27 22:42 ` Linus Torvalds
2012-04-27 22:56 ` H. Peter Anvin
2012-04-27 23:07 ` Linus Torvalds
2012-04-28 0:03 ` H. Peter Anvin
2012-04-28 0:17 ` Linus Torvalds
2012-04-27 22:42 ` Alan Cox
2012-04-27 22:49 ` Linus Torvalds
2012-04-27 23:27 ` Linus Torvalds
2012-04-28 16:10 ` Linus Torvalds
2012-04-29 6:37 ` Michael Tokarev
2012-04-29 7:19 ` Linus Torvalds
2012-04-29 7:45 ` Michael Tokarev [this message]
2012-04-29 18:29 ` Linus Torvalds
2012-04-29 19:09 ` Linus Torvalds
2012-04-29 19:53 ` Michael Tokarev
2012-04-29 20:53 ` Linus Torvalds
2012-04-30 8:41 ` Thomas Meyer
2012-04-28 1:56 ` Ian Kent
2012-04-27 19:08 ` David Miller
2012-04-27 20:45 ` H. Peter Anvin
2012-04-27 20:42 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9CF191.5020607@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=autofs@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=stable@kernel.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.