All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
	Pavel Emelianov <xemul@parallels.com>
Subject: Re: [PATCH 1/2] proc: report file/anon bit in /proc/pid/pagemap
Date: Sun, 29 Apr 2012 12:28:36 +0400	[thread overview]
Message-ID: <4F9CFBB4.2080708@openvz.org> (raw)
In-Reply-To: <CAHGf_=riWBO6-Ax0hfSU3hhxr7oXwLwtzJC55yeEpZDOjbqREg@mail.gmail.com>

KOSAKI Motohiro wrote:
>> diff --git a/Documentation/vm/pagemap.txt b/Documentation/vm/pagemap.txt
>> index 4600cbe..7587493 100644
>> --- a/Documentation/vm/pagemap.txt
>> +++ b/Documentation/vm/pagemap.txt
>> @@ -16,7 +16,7 @@ There are three components to pagemap:
>>      * Bits 0-4   swap type if swapped
>>      * Bits 5-54  swap offset if swapped
>>      * Bits 55-60 page shift (page size = 1<<page shift)
>> -    * Bit  61    reserved for future use
>> +    * Bit  61    page is file-page or shared-anon
>>      * Bit  62    page swapped
>>      * Bit  63    page present
>
> hmm..
> Here says, file or shmem.
>
>
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index 2d60492..bc3df31 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -700,6 +700,7 @@ struct pagemapread {
>>
>>   #define PM_PRESENT          PM_STATUS(4LL)
>>   #define PM_SWAP             PM_STATUS(2LL)
>> +#define PM_FILE             PM_STATUS(1LL)
>>   #define PM_NOT_PRESENT      PM_PSHIFT(PAGE_SHIFT)
>>   #define PM_END_OF_BUFFER    1
>
> But, this macro says it's file. it seems a bit misleading. ;-)

well... you know, shmem/shared-anon actually lays on tmpfs. so they really file-pages.

>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email:<a href=ilto:"dont@kvack.org">  email@kvack.org</a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
	Pavel Emelianov <xemul@parallels.com>
Subject: Re: [PATCH 1/2] proc: report file/anon bit in /proc/pid/pagemap
Date: Sun, 29 Apr 2012 12:28:36 +0400	[thread overview]
Message-ID: <4F9CFBB4.2080708@openvz.org> (raw)
In-Reply-To: <CAHGf_=riWBO6-Ax0hfSU3hhxr7oXwLwtzJC55yeEpZDOjbqREg@mail.gmail.com>

KOSAKI Motohiro wrote:
>> diff --git a/Documentation/vm/pagemap.txt b/Documentation/vm/pagemap.txt
>> index 4600cbe..7587493 100644
>> --- a/Documentation/vm/pagemap.txt
>> +++ b/Documentation/vm/pagemap.txt
>> @@ -16,7 +16,7 @@ There are three components to pagemap:
>>      * Bits 0-4   swap type if swapped
>>      * Bits 5-54  swap offset if swapped
>>      * Bits 55-60 page shift (page size = 1<<page shift)
>> -    * Bit  61    reserved for future use
>> +    * Bit  61    page is file-page or shared-anon
>>      * Bit  62    page swapped
>>      * Bit  63    page present
>
> hmm..
> Here says, file or shmem.
>
>
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index 2d60492..bc3df31 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -700,6 +700,7 @@ struct pagemapread {
>>
>>   #define PM_PRESENT          PM_STATUS(4LL)
>>   #define PM_SWAP             PM_STATUS(2LL)
>> +#define PM_FILE             PM_STATUS(1LL)
>>   #define PM_NOT_PRESENT      PM_PSHIFT(PAGE_SHIFT)
>>   #define PM_END_OF_BUFFER    1
>
> But, this macro says it's file. it seems a bit misleading. ;-)

well... you know, shmem/shared-anon actually lays on tmpfs. so they really file-pages.

>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email:<a href=ilto:"dont@kvack.org">  email@kvack.org</a>


  reply	other threads:[~2012-04-29  8:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 19:44 [PATCH] proc: Report PageAnon in last left bit of /proc/pid/pagemap Pavel Emelyanov
2012-04-20 20:32 ` Rik van Riel
2012-04-20 20:36   ` Pavel Emelyanov
2012-04-27 12:39 ` [PATCH 1/2] proc: report file/anon bit in /proc/pid/pagemap Konstantin Khlebnikov
2012-04-27 12:39   ` Konstantin Khlebnikov
2012-04-27 13:37   ` Pavel Emelyanov
2012-04-27 13:37     ` Pavel Emelyanov
2012-04-27 23:40     ` Andrew Morton
2012-04-27 23:40       ` Andrew Morton
2012-04-28 13:32   ` KOSAKI Motohiro
2012-04-28 13:32     ` KOSAKI Motohiro
2012-04-29  8:28     ` Konstantin Khlebnikov [this message]
2012-04-29  8:28       ` Konstantin Khlebnikov
2012-04-27 12:39 ` [PATCH 2/2] proc: report page->index instead of pfn for non-linear mappings " Konstantin Khlebnikov
2012-04-27 12:39   ` Konstantin Khlebnikov
2012-04-27 13:37   ` Pavel Emelyanov
2012-04-27 13:37     ` Pavel Emelyanov
2012-04-30 10:48 ` [PATCH v3] proc: report file/anon bit " Konstantin Khlebnikov
2012-04-30 10:48   ` Konstantin Khlebnikov
2012-04-30 20:32   ` KOSAKI Motohiro
2012-04-30 20:32     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9CFBB4.2080708@openvz.org \
    --to=khlebnikov@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.