From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] bug fix for bootp
Date: Sun, 29 Apr 2012 20:35:45 +0200 [thread overview]
Message-ID: <4F9D8A01.2060809@gmail.com> (raw)
In-Reply-To: <CAF-6-Q10CVuCyw=5U=M2vfkCavifaTOR5_-jTfv8RNx2NMQogA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On 29.04.2012 20:26, Bean wrote:
> Hi,
>
> It should be ok, since it's inside FOR_NET_NETWORK_LEVEL_INTERFACES
> (inf) loop and compare inf->hwaddress.mac to the current dhcp response
> packet.
It's not. You return even if packet didn't match.
> 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>:
>> On 29.04.2012 06:17, Bean wrote:
>>> Hi,
>>>
>>> DHCP offer can use multicast address, so instead of comparing the
>>> target address, we should compare the mac field in the dhcp packet.
>> Could you adjust this patch to the fact that there may be several
>> simultaneous bootp active requests from GRUB for different MAC addresses?
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>> --
>> Regards
>> Vladimir 'φ-coder/phcoder' Serbinenko
>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-04-29 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 4:17 [PATCH] bug fix for bootp Bean
2012-04-29 16:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-29 18:26 ` Bean
2012-04-29 18:35 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-04-29 18:50 ` Bean
2012-04-29 18:59 ` Bean
2012-05-01 13:20 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9D8A01.2060809@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.