From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] bug fix for bootp
Date: Tue, 01 May 2012 15:20:42 +0200 [thread overview]
Message-ID: <4F9FE32A.7080203@gmail.com> (raw)
In-Reply-To: <CAF-6-Q3Je0CkqDM8z06sSqCpwCgr24ehUzX+VvQo_jYmBYSjAQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On 29.04.2012 20:59, Bean wrote:
> 2012/4/30 Bean <bean123ch@gmail.com>:
>> 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>:
>>> On 29.04.2012 20:26, Bean wrote:
>>>> Hi,
>>>>
>>>> It should be ok, since it's inside FOR_NET_NETWORK_LEVEL_INTERFACES
>>>> (inf) loop and compare inf->hwaddress.mac to the current dhcp response
>>>> packet.
>>> It's not. You return even if packet didn't match.
>> Hi,
>>
>> Oh i see, i forget about the return a few lines beyond.
> Hi,
>
> oh, there seems to be a missing grub_netbuff_free here as well, pls
> check if this is ok.
The patch is still incorrect. Namely the problem is with netbuff_pull
being called in every loop. I've committed a fixed version.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2012-05-01 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 4:17 [PATCH] bug fix for bootp Bean
2012-04-29 16:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-29 18:26 ` Bean
2012-04-29 18:35 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-29 18:50 ` Bean
2012-04-29 18:59 ` Bean
2012-05-01 13:20 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9FE32A.7080203@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.